eric-milles commented on PR #1926:
URL: https://github.com/apache/groovy/pull/1926#issuecomment-1664170619
The changes to the plain `flatten` seem fine. The changes to the closure
variant I'm thinking about. Should you say Array, Collection and Optional
handled internally and all else goes to the closure? If the closure can bear
optionals, then you lose all guarantees of it returning `? extends T`.
```java
public static <T> Collection<T> flatten(Iterable<T> self, Closure<? extends
T> flattenUsing) {
// ^^^
^^^^^^^^^^^^^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
