[
https://issues.apache.org/jira/browse/GROOVY-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790190#comment-17790190
] ASF GitHub Bot commented on GROOVY-9962: ---------------------------------------- codecov-commenter commented on PR #2000: URL: https://github.com/apache/groovy/pull/2000#issuecomment-1828304937 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2000?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#2000](https://app.codecov.io/gh/apache/groovy/pull/2000?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (253a186) into [GROOVY_4_0_X](https://app.codecov.io/gh/apache/groovy/commit/d1f9d935f6dfa4b45e48385f1760343118bd12ed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d1f9d93) will **increase** coverage by `0.0018%`. > The diff coverage is `n/a`. <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2000?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## GROOVY_4_0_X #2000 +/- ## ====================================================== + Coverage 68.0557% 68.0575% +0.0018% Complexity 28429 28429 ====================================================== Files 1425 1425 Lines 112643 112643 Branches 19334 19334 ====================================================== + Hits 76660 76662 +2 + Misses 29442 29440 -2 Partials 6541 6541 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2000/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> > Stub generation malforms annotation values > ------------------------------------------ > > Key: GROOVY-9962 > URL: https://issues.apache.org/jira/browse/GROOVY-9962 > Project: Groovy > Issue Type: Bug > Components: Stub generator / Joint compiler > Affects Versions: 3.0.7 > Reporter: James Kleeh > Assignee: Keegan Witt > Priority: Major > Fix For: 2.5.15, 3.0.8 > > > This issue was introduced by > https://issues.apache.org/jira/browse/GROOVY-6085 and the fix > [https://github.com/apache/groovy/commit/561fad780794a5ac6be81818d2f123496e6c9bad#diff-fb5c7aed8d75294b5fbca45b00da5e20968d33704cb81720503ee3601df30fecR732] > > That commit replaces `$` with `.` in annotation values, however it seems that > should only happen if the value is a class expression. For things like string > literals it is changing the string value which is causing other problems. -- This message was sent by Atlassian Jira (v8.20.10#820010)
