eric-milles commented on PR #2023: URL: https://github.com/apache/groovy/pull/2023#issuecomment-1875712756
> source code is meant for developers to read, and the less redundant code there is, the more developer-friendly it becomes. So now you have a benefit statement that you can put in the ticket. It would be nice to have a period of review on the problem statement and cost-benefit analysis before being forced to review code in hand. If a user does not care about the extra code to read and the extra bytecode generated, is there a way to turn this off? Have you still left it as a compiler error or did you soften it to a warning? If analysis mis-identifies some code as dead code and fails compilation, what can a user do to get their previously-working code to compile? If you do not address such concerns, then why not leave this out as a global transform that you apply to your own code? Why must it be core code from the very start? It's a -1 from me unless you can more carefully spell out the problem definition and the solution ramifications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
