blackdrag commented on PR #2020:
URL: https://github.com/apache/groovy/pull/2020#issuecomment-1876951120
> Why are the methods deprecated in `MetaMethod` and `ParameterTypes`? Are
they not useful for other purposes?
There are two cases, both of them are unused.
First there is the ParameterTypes constructor, which loads types based on
String. This is something we have to be extra careful with, because this works
only if the correct class loader is used. Which means there is only a limited
use for this method in specific cases and in general we cannot use it. IMHO it
makes no sense to keep this around.
Next is the MetaMethod:
```
public void checkParameters(Class[] arguments) {
// let's check that the argument types are valid
if (!isValidMethod(arguments)) {
throw new IllegalArgumentException(
"Parameters to method: "
+ getName()
+ " do not match types: "
+ FormatHelper.toString(getParameterTypes())
+ " for arguments: "
+ FormatHelper.toString(arguments));
}
}
```
for our runtime this method has no use. We have isValidMethod instead,
which is also used in this case. The method is just a wrapper around that for
error reporting. This could be useful in theory, but I don't see why we should
keep it. I mean what is the scenario for it?
> Besides replacing with standard types, does this improve performance or
memory usage or some other characteristic?
It should be a bit more threadsafe since I use the concurrent hashmap. But I
think in department we will have to do quite a bit more work. Otherwise the
goal was no improving performance or memory usage but maintainability. It is
now much more clear what this structure is compared to before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
