[ 
https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804466#comment-17804466
 ] 

ASF GitHub Bot commented on GROOVY-11263:
-----------------------------------------

eric-milles commented on code in PR #2023:
URL: https://github.com/apache/groovy/pull/2023#discussion_r1445349235


##########
src/main/java/org/codehaus/groovy/control/CompilerConfiguration.java:
##########
@@ -66,6 +66,9 @@ public class CompilerConfiguration {
     /** Joint Compilation Option for enabling generating stubs in memory. */
     public static final String MEM_STUB = "memStub";
 
+    /** Optimization Option for enabling dead code analysis */
+    public static final String ANALYZE_DEAD_CODE = "analyzeDeadCode";
+

Review Comment:
   Can you move this adjacent to the other optimization options and add an 
`@since` tag?
   
   I'm partial to naming it `DEAD_CODE_ANALYSIS` and `"deadCodeAnalysis"`.





> Analyze dead code
> -----------------
>
>                 Key: GROOVY-11263
>                 URL: https://issues.apache.org/jira/browse/GROOVY-11263
>             Project: Groovy
>          Issue Type: New Feature
>            Reporter: Daniel Sun
>            Priority: Major
>              Labels: breaking_change
>             Fix For: 5.x
>
>
> As we all know, source code is meant for developers to read, and the less 
> redundant code there is, the more developer-friendly it becomes, but Groovy 
> allows dead code after {{throw}}, {{return}}, {{break}} and {{continue}}, e.g.
> {code:java}
> def m() {
>    return
>    def a = 1
> }
> {code}
> It's better to avoid such dead code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to