daniellansun commented on PR #2037: URL: https://github.com/apache/groovy/pull/2037#issuecomment-1902735259
> Could you add the Java 19+ build stuff separately? Sure. I just want to see if the fix works for Java 19+. > Is it possible to incorporate the non-sealed checking into isSealed() and then you would be checking !isSealed() instead of isNonSealed()? `isNonSealed()` means the type is declared `non-sealed`, it is not `sealed` and its parent must be `sealed`, so `isNonSealed()` can not just be expressed by `!isSealed()`. So I would like to accept your suggestion putting `isNonSealed()` into `ClassNodeUtils`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
