Goooler commented on code in PR #2043:
URL: https://github.com/apache/groovy/pull/2043#discussion_r1467364144
##########
build-logic/src/main/groovy/org.apache.groovy-asciidoctor.gradle:
##########
@@ -126,7 +126,7 @@ asciidoctor.onlyIf { project.file('src/spec/doc').exists() }
def asciidoctorAssets = tasks.register("asciidoctorAssets", Copy) {
from project.fileTree('src/spec/doc/assets')
- into "$buildDir/tmp/asciidoctor-assets"
+ into layout.buildDirectory.dir("tmp/asciidoc/html5/assets")
Review Comment:
```suggestion
into layout.buildDirectory.dir("tmp/asciidoctor-assets")
```
##########
build.gradle:
##########
@@ -254,7 +254,7 @@ sonarqube {
property "sonar.organization", "apache"
property "sonar.host.url", "https://sonarcloud.io";
property "sonar.cpd.exclusions", "**/*"
-// property "sonar.coverage.jacoco.xmlReportPaths",
"${rootProject.buildDir}/reports/jacoco/jacocoAllReport/jacocoAllReport.xml"
+// property "sonar.coverage.jacoco.xmlReportPaths",
layout.buildDirectory.dir("reports/jacoco/jacocoAllReport/jacocoAllReport.xml").get().asFile.absolutePath
Review Comment:
```suggestion
// property "sonar.coverage.jacoco.xmlReportPaths",
layout.buildDirectory.file("reports/jacoco/jacocoAllReport/jacocoAllReport.xml").get().asFile.absolutePath
```
##########
build-logic/src/main/groovy/org.apache.groovy-asciidoctor.gradle:
##########
@@ -53,14 +53,14 @@ asciidoctor {
sources {
include '*.adoc'
}
- outputDir = "$buildDir/asciidoc/html5"
+ outputDir = layout.buildDirectory.dir("asciidoc/html5")
resources {
duplicatesStrategy = DuplicatesStrategy.WARN
from("${rootProject.projectDir}/src/spec/doc/assets") {
include 'css/style.css'
}
- from("$buildDir/tmp/asciidoctor-assets")
+ from layout.buildDirectory.dir("asciidoc/html5/assets")
Review Comment:
```suggestion
from layout.buildDirectory.dir("tmp/asciidoctor-assets")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
