[
https://issues.apache.org/jira/browse/GROOVY-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811733#comment-17811733
] ASF GitHub Bot commented on GROOVY-11294: ----------------------------------------- codecov-commenter commented on PR #2047: URL: https://github.com/apache/groovy/pull/2047#issuecomment-1913971350 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2047?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`5aafcdf`)](https://app.codecov.io/gh/apache/groovy/commit/5aafcdf1d26874458448d329498285fab96549d6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 68.5240% compared to head [(`3cde7af`)](https://app.codecov.io/gh/apache/groovy/pull/2047?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 68.5278%. <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2047?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2047 +/- ## ================================================== + Coverage 68.5240% 68.5278% +0.0038% - Complexity 29164 29167 +3 ================================================== Files 1422 1422 Lines 113493 113494 +1 Branches 19545 19545 ================================================== + Hits 77770 77775 +5 + Misses 29181 29179 -2 + Partials 6542 6540 -2 ``` | [Files](https://app.codecov.io/gh/apache/groovy/pull/2047?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../groovy/transform/RecordTypeASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2047?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9SZWNvcmRUeXBlQVNUVHJhbnNmb3JtYXRpb24uamF2YQ==) | `86.0294% <100.0000%> (+0.0515%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2047/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> > Make generated toList() and toMap() methods on records return immutable > collections > ----------------------------------------------------------------------------------- > > Key: GROOVY-11294 > URL: https://issues.apache.org/jira/browse/GROOVY-11294 > Project: Groovy > Issue Type: Improvement > Components: record > Affects Versions: 5.x > Reporter: Oscar N > Priority: Minor > > With records having strong immutability guarantees, I believe it would make > sense to also have the collections returned by `toList()` and `toMap()` be > immutable as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
