PaintNinja commented on PR #2044: URL: https://github.com/apache/groovy/pull/2044#issuecomment-1915649600
Groovy records already rely on the runtime library - the generated toList() and toMap() use ScriptBytecodeAdapter#createList/createMap in Groovy 4 and Groovy 5 snapshots (pre this PR). As explained on the mailing list, using the runtime library allows for using Java's faster immutable List.of()/Map.of() when possible without needing many changes to the AST transform or bytecode gen. After reading some of the feedback here, on the mailing list and jira, I better understand the importance of preferring simpler approaches and will be replying to the comments and re-evaluating my PR accordingly when I have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
