[
https://issues.apache.org/jira/browse/GROOVY-11308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817210#comment-17817210
] ASF GitHub Bot commented on GROOVY-11308: ----------------------------------------- codecov-commenter commented on PR #2056: URL: https://github.com/apache/groovy/pull/2056#issuecomment-1943095932 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2056?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`4725c43`)](https://app.codecov.io/gh/apache/groovy/commit/4725c433feb896b488f3512e938e5ff6833baaaa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 68.5281% compared to head [(`e17ebc6`)](https://app.codecov.io/gh/apache/groovy/pull/2056?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 68.5311%. <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2056?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2056 +/- ## ================================================== + Coverage 68.5281% 68.5311% +0.0030% + Complexity 29177 29176 -1 ================================================== Files 1422 1422 Lines 113495 113493 -2 Branches 19548 19547 -1 ================================================== + Hits 77776 77778 +2 + Misses 29178 29175 -3 + Partials 6541 6540 -1 ``` | [Files](https://app.codecov.io/gh/apache/groovy/pull/2056?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../codehaus/groovy/runtime/DefaultGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2056?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRGVmYXVsdEdyb292eU1ldGhvZHMuamF2YQ==) | `73.6213% <100.0000%> (+0.0157%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2056/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> > DefaultGroovyMethods#unique now returns null for empty or 1 element input > ------------------------------------------------------------------------- > > Key: GROOVY-11308 > URL: https://issues.apache.org/jira/browse/GROOVY-11308 > Project: Groovy > Issue Type: Bug > Components: groovy-runtime > Affects Versions: 3.0.21, 4.0.19, 5.0.0-alpha-6 > Reporter: Octavia Togami > Priority: Critical > > https://github.com/apache/groovy/commit/c181ef72e442f1d51855e0db6d44ab302cf7c662 > changed the behavior of {{DefaultGroovyMethods#unique}} to return {{null}} > for an empty or one element collection input when {{mutate}} is {{false}}. > This requires a really awkward workaround and breaks compatibility with > previous versions, and I personally don't think the behavior makes sense. -- This message was sent by Atlassian Jira (v8.20.10#820010)
