[
https://issues.apache.org/jira/browse/GROOVY-11432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863007#comment-17863007
] ASF GitHub Bot commented on GROOVY-11432: ----------------------------------------- codecov-commenter commented on PR #2097: URL: https://github.com/apache/groovy/pull/2097#issuecomment-2208726244 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2097?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 68.6371%. Comparing base [(`6cd477b`)](https://app.codecov.io/gh/apache/groovy/commit/6cd477b3157675f0ceee9fbd62e3efd0cc9bdb3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`570fcbc`)](https://app.codecov.io/gh/apache/groovy/commit/570fcbc7400b10fa7d3f836c950b52a4eec6f575?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 167 commits behind head on master. <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2097?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2097 +/- ## ================================================== + Coverage 68.5957% 68.6371% +0.0414% - Complexity 29233 29331 +98 ================================================== Files 1426 1426 Lines 113494 113615 +121 Branches 19548 19594 +46 ================================================== + Hits 77852 77982 +130 + Misses 29088 29087 -1 + Partials 6554 6546 -8 ``` | [Files](https://app.codecov.io/gh/apache/groovy/pull/2097?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/2097?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==) | `86.6075% <100.0000%> (-0.0235%)` | :arrow_down: | | [...rg/codehaus/groovy/classgen/AnnotationVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2097?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FAnnotationVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL0Fubm90YXRpb25WaXNpdG9yLmphdmE=) | `88.6667% <100.0000%> (ø)` | | ... and [43 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2097/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> > Explore whether we should add method references to annotations > -------------------------------------------------------------- > > Key: GROOVY-11432 > URL: https://issues.apache.org/jira/browse/GROOVY-11432 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Priority: Major > > The topic (for Java) appeared on social media recently: > https://twitter.com/GeoffreyDeSmet/status/1808216150867861896 > Java thought it might be a good idea a while back but thought it would be > hard to implement: > https://mail.openjdk.org/pipermail/core-libs-dev/2018-November/056596.html > For us we could use a Class typed annotation attribute and do like we > currently do for closures, e.g.: > {code} > @interface UIColorAnnotation { > Class method() > } > @UIColorAnnotation(method = Person::getAgeColor) > public int getAge() { > } > ... > {code} > Since we already support closures, my thinking is to make the above exactly > equivalent to: > {code} > @UIColorAnnotation(method = { with(Person::getAgeColor) }) > public int getAge() { > } > ... > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
