[ 
https://issues.apache.org/jira/browse/GROOVY-11415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877831#comment-17877831
 ] 

Eric Milles commented on GROOVY-11415:
--------------------------------------

We're now 3 commits in and I renew my request to remove this from Groovy 4 and 
reconsider why this change was made for Groovy 5 with little explanation.  
Again, static compilation makes this optimization already.

https://github.com/apache/groovy/commit/c222d7196925717708170fd8652d81565049add8
https://github.com/apache/groovy/commit/5ec593d588badb99daa48dde9f9242ea6291f1ba
https://github.com/apache/groovy/commit/7f5f7d9ea4db7c0fccf5b9ddb01011d60d502c16

> Bytecode for identity
> ---------------------
>
>                 Key: GROOVY-11415
>                 URL: https://issues.apache.org/jira/browse/GROOVY-11415
>             Project: Groovy
>          Issue Type: Improvement
>            Reporter: Daniel Sun
>            Assignee: Daniel Sun
>            Priority: Major
>             Fix For: 5.0.0-alpha-9, 4.0.22
>
>
> The bytecode for {{===}} and {{!==}} is to invoke static method, e.g. 
> \{{compareIdentical}}, \{{compareNotIdentical}}.
> We could generate better bytecode by leveraging \{{IF_ACMPEQ}}, 
> \{{IF_ACMPNE}}, which is same to the bytecode generated by Java compiler.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to