[ 
https://issues.apache.org/jira/browse/GROOVY-11415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878134#comment-17878134
 ] 

Eric Milles edited comment on GROOVY-11415 at 9/4/24 3:25 PM:
--------------------------------------------------------------

In any case, I asked at the time this was originally committed why it was put 
into Groovy 4. I have lost track of my original comments and I think my -1 for 
the 4.0.22 release got lost due to a mailing list infra issue.

I do not understand why the bytecode should be changed in a point release 
unless it is fixing a major issue. Having such a change in only Groovy 5 gives 
time for discussion and refinement.


was (Author: emilles):
In any case, I asked at the time this was originally committed why it was put 
into Groovy 4.  I have lost track of my original comments and I think my -1 for 
the 4.0.22 release got lost due to a mailing list infra issue.

I do not understand why the bytecode should be changed in a point release 
unless it is fixing a major issue.  Having such a change in Groovy 5 only gives 
time for discussion and refinement.

> Bytecode for identity
> ---------------------
>
>                 Key: GROOVY-11415
>                 URL: https://issues.apache.org/jira/browse/GROOVY-11415
>             Project: Groovy
>          Issue Type: Improvement
>            Reporter: Daniel Sun
>            Priority: Major
>
> The bytecode for {{===}} and {{!==}} is to invoke static method, e.g. 
> \{{compareIdentical}}, \{{compareNotIdentical}}.
> We could generate better bytecode by leveraging \{{IF_ACMPEQ}}, 
> \{{IF_ACMPNE}}, which is same to the bytecode generated by Java compiler.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to