[ https://issues.apache.org/jira/browse/GROOVY-11647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul King updated GROOVY-11647: ------------------------------- Description: Original discussion: https://lists.apache.org/thread/xv1bpgc7xp3rwp7qt627xfyd10ljcwbc This issue is splitting out the {{findIndexValues}} methods. Rather than creating {{findingIndexValues}} methods, we think the Iterator variant of this method is used rarely enough that giving it the same treatment as {{chop}} by changing the return type and providing a bridge method is the better path. There are two cases to consider: # When the findIndexValues call is followed by some other chained calls (or calls in subsequent statements), there will typically be no change needed, assuming some terminal-like operator is eventually in the chain of calls. # When the findIndexValues call is last, calls like "iter.findIndexValues()" would need to change to "iter.toList().findIndexValues()" or "iter.findIndexValues().toList()". was: See: https://lists.apache.org/thread/xv1bpgc7xp3rwp7qt627xfyd10ljcwbc > Change return type of DGM#findIndexValues(Iterator) methods > ----------------------------------------------------------- > > Key: GROOVY-11647 > URL: https://issues.apache.org/jira/browse/GROOVY-11647 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > Labels: breaking > > Original discussion: > https://lists.apache.org/thread/xv1bpgc7xp3rwp7qt627xfyd10ljcwbc > This issue is splitting out the {{findIndexValues}} methods. Rather than > creating {{findingIndexValues}} methods, we think the Iterator variant of > this method is used rarely enough that giving it the same treatment as > {{chop}} by changing the return type and providing a bridge method is the > better path. > There are two cases to consider: > # When the findIndexValues call is followed by some other chained calls (or > calls in subsequent statements), there will typically be no change needed, > assuming some terminal-like operator is eventually in the chain of calls. > # When the findIndexValues call is last, calls like "iter.findIndexValues()" > would need to change to "iter.toList().findIndexValues()" or > "iter.findIndexValues().toList()". -- This message was sent by Atlassian Jira (v8.20.10#820010)