[
https://issues.apache.org/jira/browse/GROOVY-11642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949294#comment-17949294
]
ASF GitHub Bot commented on GROOVY-11642:
-----------------------------------------
codecov-commenter commented on PR #2211:
URL: https://github.com/apache/groovy/pull/2211#issuecomment-2849276591
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2211?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 68.9576%. Comparing base
[(`71ca3e0`)](https://app.codecov.io/gh/apache/groovy/commit/71ca3e07d43bbf60e80f2464d6e79ab56d0b581e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`468f1ea`)](https://app.codecov.io/gh/apache/groovy/commit/468f1ea2db15b9a7d85eb92fcabd65d9cf8cd1ef?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2211 +/- ##
=============================================
Coverage 68.9576% 68.9576%
- Complexity 29591 29593 +2
=============================================
Files 1423 1423
Lines 114102 114102
Branches 19793 19793
=============================================
Hits 78682 78682
- Misses 28800 28801 +1
+ Partials 6620 6619 -1
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2211?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/2211?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==)
| `86.5333% <100.0000%> (ø)` | |
... and [2 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2211/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> source offset of inner class declaration with annotation
> --------------------------------------------------------
>
> Key: GROOVY-11642
> URL: https://issues.apache.org/jira/browse/GROOVY-11642
> Project: Groovy
> Issue Type: Bug
> Components: parser-antlr4
> Reporter: Eric Milles
> Assignee: Eric Milles
> Priority: Major
>
> Consider the following:
> {code:groovy}
> class Outer {
> @Deprecated
> public class Inner {
> }
> }
> {code}
> Under the old parser, the source range for {{Inner}} starts at the
> annotation. The new parser starts at the line and column of the {{class}}
> keyword. You can compare against how an outer class with an annotation gets
> ranged.
> This line does not expand the source range using {{ctx}} as is done for an
> outer class.
> https://github.com/apache/groovy/blob/1eeb735e303fdb230feb03ea3b3f44f7e7750e66/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java#L1584
> It is possible that the other member options -- method, field and compact
> constructor -- also fail to include the range of other annotations /
> modifiers. I have not checked, but it looks suspect.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
