[
https://issues.apache.org/jira/browse/GROOVY-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950342#comment-17950342
] ASF GitHub Bot commented on GROOVY-11616: ----------------------------------------- codecov-commenter commented on PR #2219: URL: https://github.com/apache/groovy/pull/2219#issuecomment-2863685655 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2219?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `80.00000%` with `1 line` in your changes missing coverage. Please review. > Project coverage is 68.9986%. Comparing base [(`14fcb08`)](https://app.codecov.io/gh/apache/groovy/commit/14fcb08c0c2665d52ffdcd5b7aeeb30a06d6b1b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`50d035a`)](https://app.codecov.io/gh/apache/groovy/commit/50d035aa9f3c3742acaca5df35e195f7e714f817?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2219?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...roovy/transform/stc/StaticTypeCheckingSupport.java](https://app.codecov.io/gh/apache/groovy/pull/2219?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nU3VwcG9ydC5qYXZh) | 80.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2219 +/- ## ================================================== + Coverage 68.9982% 68.9986% +0.0005% - Complexity 29659 29660 +1 ================================================== Files 1423 1423 Lines 114319 114324 +5 Branches 19832 19835 +3 ================================================== + Hits 78878 78882 +4 + Misses 28811 28809 -2 - Partials 6630 6633 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2219?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2219?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh) | `87.4718% <ø> (ø)` | | | [...roovy/transform/stc/StaticTypeCheckingSupport.java](https://app.codecov.io/gh/apache/groovy/pull/2219?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nU3VwcG9ydC5qYXZh) | `81.6622% <80.0000%> (-0.0075%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2219/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Functions that take var args will default the type of the first argument, > java tries to find the common parent type from all arguments > -------------------------------------------------------------------------------------------------------------------------------------- > > Key: GROOVY-11616 > URL: https://issues.apache.org/jira/browse/GROOVY-11616 > Project: Groovy > Issue Type: Bug > Components: Static Type Checker > Affects Versions: 4.0.24, 5.0.0-alpha-12 > Reporter: Saravanan > Assignee: Eric Milles > Priority: Minor > > > {code:java} > public class Interfaces { > class Blah { > } > class BlahBlah extends Blah { > } > class BlahBlahBlah extends Blah { > } > public String myThing() { > // This fails with > // Incompatible generic argument types. Cannot assign > java.util.List<? extends com.org.interfaces.Interfaces.Blah> > // to: java.util.List<com.org.interfaces.Interfaces.Blah> > // To fix change to explicitly define generic type > // Arrays.<Blah> asList(...) > List<Blah> myArray = Arrays.asList(new Blah(), new BlahBlah(), new > BlahBlahBlah(), new Blah()); > } > } > {code} > Arrays.asList takes a vararg parameter. Groovy defaults to assuming that the > first parameter type is the type (or parent type) for all parameters that > follow. If we use instances of multiple derived types, Groovy errors out > without trying to find the common parent type -- This message was sent by Atlassian Jira (v8.20.10#820010)
