[
https://issues.apache.org/jira/browse/GROOVY-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016642#comment-18016642
] ASF GitHub Bot commented on GROOVY-11745: ----------------------------------------- codecov-commenter commented on PR #2284: URL: https://github.com/apache/groovy/pull/2284#issuecomment-3229776144 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2284?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `27.27273%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.0011%. Comparing base ([`8b8eb11`](https://app.codecov.io/gh/apache/groovy/commit/8b8eb1163bf4fbd39b8090baa082a9638df6f5ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`54bf508`](https://app.codecov.io/gh/apache/groovy/commit/54bf508ee3158b1da0495b10df83b0f5285402bb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2284?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...codehaus/groovy/runtime/ScriptBytecodeAdapter.java](https://app.codecov.io/gh/apache/groovy/pull/2284?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FScriptBytecodeAdapter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvU2NyaXB0Qnl0ZWNvZGVBZGFwdGVyLmphdmE=) | 30.0000% | [2 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/2284?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=) | 0.0000% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2284 +/- ## ================================================== - Coverage 67.0034% 67.0011% -0.0023% - Complexity 29273 29275 +2 ================================================== Files 1382 1382 Lines 116512 116510 -2 Branches 20393 20394 +1 ================================================== - Hits 78067 78063 -4 Misses 32035 32035 - Partials 6410 6412 +2 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2284?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/2284?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=) | `78.2848% <0.0000%> (ø)` | | | [...codehaus/groovy/runtime/ScriptBytecodeAdapter.java](https://app.codecov.io/gh/apache/groovy/pull/2284?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FScriptBytecodeAdapter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvU2NyaXB0Qnl0ZWNvZGVBZGFwdGVyLmphdmE=) | `67.5481% <30.0000%> (-1.1122%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2284/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Groovy5 calling Groovy4 library with setter throws NPE > ------------------------------------------------------ > > Key: GROOVY-11745 > URL: https://issues.apache.org/jira/browse/GROOVY-11745 > Project: Groovy > Issue Type: Bug > Affects Versions: 4.0.28, 5.0.0 > Reporter: Aleks Tamarkin > Assignee: Eric Milles > Priority: Major > > When Groovy5 calls Groovy4 code that sets a property which should be calling > a setter under the hood, an NPE is thrown. > The stack looks like > > {code:java} > Exception in thread "main" java.lang.NullPointerException > at java.base/java.lang.Class.isAssignableFrom(Native Method) > at groovy.lang.MetaClassImpl.isVisibleProperty(MetaClassImpl.java:2104) > at groovy.lang.MetaClassImpl.setProperty(MetaClassImpl.java:2761) > at > org.codehaus.groovy.runtime.ScriptBytecodeAdapter.setProperty(ScriptBytecodeAdapter.java:509){code} > I am seeing this error fairly randomly on setters. > One example in the Groovy4 code being called by Groovy5 looks like > {code:java} > HttpURLConnection c = "<someUrl>".toURL().openConnection() as > HttpURLConnection > ... > c.useCaches = false // this line has the error{code} > -- This message was sent by Atlassian Jira (v8.20.10#820010)
