[
https://issues.apache.org/jira/browse/GROOVY-11601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018455#comment-18018455
] ASF GitHub Bot commented on GROOVY-11601: ----------------------------------------- codecov-commenter commented on PR #2289: URL: https://github.com/apache/groovy/pull/2289#issuecomment-3259259013 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2289?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.00000%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.9881%. Comparing base ([`dd37d71`](https://app.codecov.io/gh/apache/groovy/commit/dd37d71e9739a6ad3219c76643ea1f7d8bb33a49?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2437ca`](https://app.codecov.io/gh/apache/groovy/commit/a2437caa3b4268665f382f148378420d674b237a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2289?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/2289?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==) | 60.0000% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2289 +/- ## ================================================== - Coverage 66.9933% 66.9881% -0.0052% + Complexity 29290 29288 -2 ================================================== Files 1382 1382 Lines 116546 116549 +3 Branches 20404 20405 +1 ================================================== - Hits 78078 78074 -4 - Misses 32050 32054 +4 - Partials 6418 6421 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2289?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/2289?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==) | `86.6222% <60.0000%> (-0.0267%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2289/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > remove support for expression list in for-each statement > -------------------------------------------------------- > > Key: GROOVY-11601 > URL: https://issues.apache.org/jira/browse/GROOVY-11601 > Project: Groovy > Issue Type: Improvement > Components: parser-antlr4 > Reporter: Eric Milles > Assignee: Eric Milles > Priority: Minor > Fix For: 5.0.0-beta-2 > > > The for-each loop supports an arbitrary expression list. Presumably this is > for legacy reasons. Now that multi-variable declaration is supported by > for-each and classic for, it does not seem necessary to support expression > list. I propose to remove it from the parser grammar. -- This message was sent by Atlassian Jira (v8.20.10#820010)
