[ https://issues.apache.org/jira/browse/GROOVY-11753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18019204#comment-18019204 ]
ASF GitHub Bot commented on GROOVY-11753: ----------------------------------------- codecov-commenter commented on PR #2291: URL: https://github.com/apache/groovy/pull/2291#issuecomment-3271589070 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2291?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.9904%. Comparing base ([`c0da6b4`](https://app.codecov.io/gh/apache/groovy/commit/c0da6b4943aebd8468df386cbc08ff03a9c21bb8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`549ea8f`](https://app.codecov.io/gh/apache/groovy/commit/549ea8f4c874c4d5bbee951b9b591e412c72e55a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2291 +/- ## ================================================== - Coverage 66.9913% 66.9904% -0.0009% - Complexity 29291 29293 +2 ================================================== Files 1382 1382 Lines 116548 116554 +6 Branches 20405 20407 +2 ================================================== + Hits 78077 78080 +3 - Misses 32050 32052 +2 - Partials 6421 6422 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2291?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...in/java/org/codehaus/groovy/classgen/Verifier.java](https://app.codecov.io/gh/apache/groovy/pull/2291?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FVerifier.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL1ZlcmlmaWVyLmphdmE=) | `89.7704% <100.0000%> (-0.0406%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2291/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Compilation error: Can't have an abstract method in a non-abstract class > ------------------------------------------------------------------------ > > Key: GROOVY-11753 > URL: https://issues.apache.org/jira/browse/GROOVY-11753 > Project: Groovy > Issue Type: Bug > Affects Versions: 5.0.0, 5.0.1 > Reporter: Mattias Reichel > Assignee: Eric Milles > Priority: Major > > I'm having a hard time reproducing this outside the Grails codebase. > To reproduce: > {noformat} > git clone https://github.com/matrei/grails-core.git > cd grails-core > git checkout groovy-5 # or 9538ca0c458e08f175e57618d0cefc24b59467f4 > ./gradlew grails-core:compileGroovy{noformat} > > > {noformat} > /home/mattias/Projects/grails-core/grails-core/src/main/groovy/grails/boot/config/tools/ProfilingGrailsApplicationPostProcessor.groovy: > 35: Can't have an abstract method in a non-abstract class. The class > 'grails.boot.config.tools.ProfilingGrailsApplicationPostProcessor' must be > declared abstract or the method 'void onApplicationEvent(E)' must be > implemented. > @ line 35, column 1. > class ProfilingGrailsApplicationPostProcessor extends > GrailsApplicationPostProcessor implements BeanPostProcessor { > ^ > 1 error > {noformat} > Build scan: [https://ge.grails.org/s/3xq27upwbybta] > or > {noformat} > ./gradlew grails-shell-cli:compileGroovy{noformat} > > {noformat} > /home/mattias/Projects/grails-core/grails-shell-cli/src/main/groovy/org/grails/cli/profile/commands/CreatePluginCommand.groovy: > 34: Can't have an abstract method in a non-abstract class. The class > 'org.grails.cli.profile.commands.CreatePluginCommand' must be declared > abstract or the method 'void > setProfileRepository(org.grails.cli.profile.ProfileRepository)' must be > implemented. > @ line 34, column 1. > @CompileStatic > ^ > 2 errors > {noformat} > Build scan: https://ge.grails.org/s/fgzr4cyi6ji7k > -- This message was sent by Atlassian Jira (v8.20.10#820010)