[
https://issues.apache.org/jira/browse/GROOVY-11675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18020931#comment-18020931
] ASF GitHub Bot commented on GROOVY-11675: ----------------------------------------- codecov-commenter commented on PR #2297: URL: https://github.com/apache/groovy/pull/2297#issuecomment-3303308626 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2297?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `75.00000%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.0086%. Comparing base ([`7ba2f25`](https://app.codecov.io/gh/apache/groovy/commit/7ba2f2548deb95cf7d9e9ddbd6904242d20cf571?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`db35407`](https://app.codecov.io/gh/apache/groovy/commit/db354078e4584a76fa846c6959628b4a60aba7cd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2297?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...g/codehaus/groovy/ast/tools/PropertyNodeUtils.java](https://app.codecov.io/gh/apache/groovy/pull/2297?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2Ftools%2FPropertyNodeUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC90b29scy9Qcm9wZXJ0eU5vZGVVdGlscy5qYXZh) | 75.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2297?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2297?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2297 +/- ## ================================================== + Coverage 67.0017% 67.0086% +0.0069% - Complexity 29302 29306 +4 ================================================== Files 1382 1382 Lines 116591 116594 +3 Branches 20410 20411 +1 ================================================== + Hits 78118 78128 +10 + Misses 32052 32046 -6 + Partials 6421 6420 -1 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2297?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...g/codehaus/groovy/ast/tools/PropertyNodeUtils.java](https://app.codecov.io/gh/apache/groovy/pull/2297?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2Ftools%2FPropertyNodeUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC90b29scy9Qcm9wZXJ0eU5vZGVVdGlscy5qYXZh) | `60.0000% <75.0000%> (+10.0000%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2297/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > split property definitions aren't carrying final modifier to getters > -------------------------------------------------------------------- > > Key: GROOVY-11675 > URL: https://issues.apache.org/jira/browse/GROOVY-11675 > Project: Groovy > Issue Type: Bug > Components: Compiler > Affects Versions: 4.0.24, 4.0.25, 4.0.26 > Reporter: Paul King > Assignee: Eric Milles > Priority: Minor > > Split property definitions were created as an alternative to the full > long-hand way to express a property. They allow modifiers (final and > synchronized), and annotations to be applied to either the backing field or > the accessors. > > {code:groovy} > import groovy.transform.PackageScope > class MyTask { > @Deprecated private final Integer f1 = 0 > final Integer f1 > protected synchronized Integer f2 = 0 > synchronized Integer f2 > public Integer f3 = 0 > @Deprecated Integer f3 > } > println MyTask > {code} > Currently, everything is carried across except for the final on the {{f1}} > accessor methods. -- This message was sent by Atlassian Jira (v8.20.10#820010)
