[
https://issues.apache.org/jira/browse/GROOVY-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18028875#comment-18028875
]
ASF GitHub Bot commented on GROOVY-11776:
-----------------------------------------
codecov-commenter commented on PR #2316:
URL: https://github.com/apache/groovy/pull/2316#issuecomment-3387302642
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2316?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 67.0143%. Comparing base
([`e09380f`](https://app.codecov.io/gh/apache/groovy/commit/e09380fe6289bdc7f107c509723fbcaa2d5479e8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`8515f5e`](https://app.codecov.io/gh/apache/groovy/commit/8515f5edaff193114cf08203dc01649656b0ba74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2316 +/- ##
==================================================
+ Coverage 67.0089% 67.0143% +0.0054%
- Complexity 29309 29312 +3
==================================================
Files 1382 1382
Lines 116592 116593 +1
Branches 20410 20410
==================================================
+ Hits 78127 78134 +7
+ Misses 32039 32036 -3
+ Partials 6426 6423 -3
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2316?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...codehaus/groovy/transform/trait/TraitComposer.java](https://app.codecov.io/gh/apache/groovy/pull/2316?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Ftrait%2FTraitComposer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS90cmFpdC9UcmFpdENvbXBvc2VyLmphdmE=)
| `82.9582% <100.0000%> (+0.0550%)` | :arrow_up: |
... and [4 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2316/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Overload resolution of trait methods does not work properly
> -----------------------------------------------------------
>
> Key: GROOVY-11776
> URL: https://issues.apache.org/jira/browse/GROOVY-11776
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 2.5.23, 4.0.26, 3.0.25, 5.0.1
> Reporter: Björn Kautler
> Assignee: Eric Milles
> Priority: Major
>
> Given this snippet:
> {code:groovy}
> trait Foo {
> def foo(Object o) {
> println("foo(o)")
> }
> def foo(Map<String, Object> m) {
> println("foo(m)")
> }
> }
> class Bar implements Foo {
> def bar(Object o) {
> println("bar(o)")
> }
> def bar(Map<String, Object> m) {
> println("bar(m)")
> }
> }
> new Bar().with {
> foo((Object) null)
> foo(null as Object)
> bar((Object) null)
> bar(null as Object)
> }
> (new Object() as Foo).with {
> foo((Object) null)
> foo(null as Object)
> }
> {code}
> In Groovy 2.5, 3.0 and 4.0 {{bar}} uses the {{Object}} variant as expected,
> but {{foo}} uses the {{Map}} variant for some reason.
> In Groovy 5.0.alpha that is still on groovyconsole.dev this was fixed and
> both used the {{Object}} variant as expected.
> In 5.0.1 this is also broken again, behaving like before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
