[
https://issues.apache.org/jira/browse/GROOVY-11790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18031477#comment-18031477
] ASF GitHub Bot commented on GROOVY-11790: ----------------------------------------- codecov-commenter commented on PR #2321: URL: https://github.com/apache/groovy/pull/2321#issuecomment-3427553378 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2321?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `40.00000%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.0014%. Comparing base ([`a20c827`](https://app.codecov.io/gh/apache/groovy/commit/a20c8279cc9fc977c0a4a530937b8febc82dc9ee?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`78910aa`](https://app.codecov.io/gh/apache/groovy/commit/78910aac0b7ad8d3793ee6e3b005d5fb5c9d30ae?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2321?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...codehaus/groovy/tools/javac/JavacJavaCompiler.java](https://app.codecov.io/gh/apache/groovy/pull/2321?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fjavac%2FJavacJavaCompiler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3Rvb2xzL2phdmFjL0phdmFjSmF2YUNvbXBpbGVyLmphdmE=) | 40.0000% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2321 +/- ## ================================================== - Coverage 67.0066% 67.0014% -0.0052% - Complexity 29324 29330 +6 ================================================== Files 1382 1382 Lines 116599 116608 +9 Branches 20425 20430 +5 ================================================== Hits 78129 78129 - Misses 32034 32037 +3 - Partials 6436 6442 +6 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2321?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...codehaus/groovy/tools/javac/JavacJavaCompiler.java](https://app.codecov.io/gh/apache/groovy/pull/2321?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fjavac%2FJavacJavaCompiler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3Rvb2xzL2phdmFjL0phdmFjSmF2YUNvbXBpbGVyLmphdmE=) | `70.5263% <40.0000%> (-2.7295%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2321/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > java-aware compilation unit: pass along target bytecode configuration > --------------------------------------------------------------------- > > Key: GROOVY-11790 > URL: https://issues.apache.org/jira/browse/GROOVY-11790 > Project: Groovy > Issue Type: Improvement > Components: Stub generator / Joint compiler > Reporter: Eric Milles > Assignee: Eric Milles > Priority: Minor > > When compiling java sources (via {{JavaAwareCompilationUnit}} / > {{JavacJavaCompiler}}) the target bytecode configuration is not propagated to > the java compiler. If no "\-source", "\-target" or "--release" parameters > are supplied, read from {{CompilerConfiguration#getTargetBytecode}}. -- This message was sent by Atlassian Jira (v8.20.10#820010)
