[
https://issues.apache.org/jira/browse/GROOVY-11798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18037539#comment-18037539
]
ASF GitHub Bot commented on GROOVY-11798:
-----------------------------------------
codecov-commenter commented on PR #2333:
URL: https://github.com/apache/groovy/pull/2333#issuecomment-3518944615
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2333?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 66.9925%. Comparing base
([`fc8b34a`](https://app.codecov.io/gh/apache/groovy/commit/fc8b34aaa76a5e19846e1d4f77cf39e9227d9690?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`cc02132`](https://app.codecov.io/gh/apache/groovy/commit/cc02132b166b73998560203e166aeaaa7c5e6af2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2333 +/- ##
==================================================
- Coverage 66.9937% 66.9925% -0.0011%
Complexity 29330 29330
==================================================
Files 1382 1382
Lines 116614 116616 +2
Branches 20433 20433
==================================================
Hits 78124 78124
- Misses 32056 32058 +2
Partials 6434 6434
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2333?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[src/main/java/groovy/util/logging/Log4j2.java](https://app.codecov.io/gh/apache/groovy/pull/2333?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Futil%2Flogging%2FLog4j2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvdXRpbC9sb2dnaW5nL0xvZzRqMi5qYXZh)
| `100.0000% <100.0000%> (ø)` | |
... and [3 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2333/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> @Log4j2 uses Logger class from log4j-core instead of log4j-api
> --------------------------------------------------------------
>
> Key: GROOVY-11798
> URL: https://issues.apache.org/jira/browse/GROOVY-11798
> Project: Groovy
> Issue Type: Bug
> Reporter: BenS
> Assignee: Eric Milles
> Priority: Major
>
> The
> [transformation|https://github.com/apache/groovy/blob/d0540bcf352425165701eedbb02172b0bcaed7ee/src/main/java/groovy/util/logging/Log4j2.java#L80]
> used by the {{@Log4j2}} annotation utilizes
> {{org.apache.logging.log4j.core.Logger}} from the log4j-core library, which
> is the implementation for the logging system, when it should be using
> {{org.apache.logging.log4j.Logger}} from the log4j-api library, which is the
> interface that should be accessed by the code directly. While the current
> configuration does technically function, it requires the logging
> implementation to be available at compilation time as opposed to only at
> runtime as described by the [Log4j
> documentation|https://logging.apache.org/log4j/2.x/manual/installation.html].
> Additionally, [Groovy's documentation|http://example.com/] for the annotation
> does not accurately reflect the transformation and indicates that it _does_
> use the api's Logger.
>
> Please let me know if any further information is required.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
