[
https://issues.apache.org/jira/browse/GROOVY-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18040078#comment-18040078
] ASF GitHub Bot commented on GROOVY-11762: ----------------------------------------- codecov-commenter commented on PR #2339: URL: https://github.com/apache/groovy/pull/2339#issuecomment-3566879490 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2339?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `93.75000%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.0017%. Comparing base ([`efcca24`](https://app.codecov.io/gh/apache/groovy/commit/efcca247920b33aaead5f7f6bb166bf177b5726b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`240e315`](https://app.codecov.io/gh/apache/groovy/commit/240e31518a7589d49d000130b7cc11de72cf0749?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2339?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/2339?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=) | 93.7500% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2339 +/- ## ================================================== + Coverage 66.9954% 67.0017% +0.0063% - Complexity 29334 29342 +8 ================================================== Files 1382 1382 Lines 116611 116600 -11 Branches 20433 20431 -2 ================================================== Hits 78124 78124 + Misses 32055 32050 -5 + Partials 6432 6426 -6 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2339?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/2339?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=) | `78.6031% <93.7500%> (+0.3662%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2339/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > callable property field shadowing > --------------------------------- > > Key: GROOVY-11762 > URL: https://issues.apache.org/jira/browse/GROOVY-11762 > Project: Groovy > Issue Type: Bug > Affects Versions: 5.0.1 > Reporter: Eric Milles > Assignee: Eric Milles > Priority: Major > > One case missed by GROOVY-8283 is that of callable property. Consider the > following: > {code:groovy} > import java.util.concurrent.Callable > class A { > Callable getThing() { > return { println "call A" } > } > } > class B extends A { > protected Callable thing = { println "call B" } > } > class C extends B { > void test() { > thing() > } > } > new C().test() > {code} > This prints "call A". However, the rules established in 8283 suggest it > should print "call B". -- This message was sent by Atlassian Jira (v8.20.10#820010)
