[ 
https://issues.apache.org/jira/browse/GROOVY-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18040214#comment-18040214
 ] 

ASF GitHub Bot commented on GROOVY-11779:
-----------------------------------------

codecov-commenter commented on PR #2341:
URL: https://github.com/apache/groovy/pull/2341#issuecomment-3568773318

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2341?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :x: Patch coverage is `82.35294%` with `3 lines` in your changes missing 
coverage. Please review.
   :white_check_mark: Project coverage is 66.9968%. Comparing base 
([`efcca24`](https://app.codecov.io/gh/apache/groovy/commit/efcca247920b33aaead5f7f6bb166bf177b5726b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`d492da5`](https://app.codecov.io/gh/apache/groovy/commit/d492da517013e70f80f106282fc1cacc98e3b196?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2341?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[.../codehaus/groovy/runtime/DefaultGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2341?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FDefaultGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRGVmYXVsdEdyb292eU1ldGhvZHMuamF2YQ==)
 | 82.3529% | [0 Missing and 3 partials :warning: 
](https://app.codecov.io/gh/apache/groovy/pull/2341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/2341/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/2341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #2341        +/-   ##
   ==================================================
   + Coverage     66.9954%   66.9968%   +0.0014%     
   - Complexity      29334      29336         +2     
   ==================================================
     Files            1382       1382                
     Lines          116611     116619         +8     
     Branches        20433      20437         +4     
   ==================================================
   + Hits            78124      78131         +7     
   + Misses          32055      32054         -1     
   - Partials         6432       6434         +2     
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2341?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../codehaus/groovy/runtime/DefaultGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2341?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FDefaultGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRGVmYXVsdEdyb292eU1ldGhvZHMuamF2YQ==)
 | `74.8025% <82.3529%> (+0.1178%)` | :arrow_up: |
   
   ... and [4 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/2341/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> Object#dump should consider properties when fields are not accessible
> ---------------------------------------------------------------------
>
>                 Key: GROOVY-11779
>                 URL: https://issues.apache.org/jira/browse/GROOVY-11779
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 5.0.1
>            Reporter: Björn Kautler
>            Priority: Major
>
> Given this snippet:
> {code:groovy}
> class Person {
>     String name
>     int age
> }
> new Person(age: 18, name: 'Foo').dump()
> {code}
> With Groovy 4 this returns the expected {{<Person@689851fa name=Foo age=18>}}.
> With Groovy 5 you get {{<Person@3d0b9ee6 name=inaccessible 
> age=inaccessible>}}.
> It would be nice if also with Groovy 5 you would get the proper information, 
> especially when the fields are exposed as properties.
> The Spock power assertion output got way less helpful with just 
> {{inaccessible}} there.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to