[ 
https://issues.apache.org/jira/browse/GROOVY-10198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041418#comment-18041418
 ] 

ASF GitHub Bot commented on GROOVY-10198:
-----------------------------------------

codecov-commenter commented on PR #2345:
URL: https://github.com/apache/groovy/pull/2345#issuecomment-3590817996

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2345?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :x: Patch coverage is `81.48148%` with `5 lines` in your changes missing 
coverage. Please review.
   :white_check_mark: Project coverage is 66.9926%. Comparing base 
([`5acebda`](https://app.codecov.io/gh/apache/groovy/commit/5acebda191d346b531ceaa7ee0b08cd03fe04651?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`616e030`](https://app.codecov.io/gh/apache/groovy/commit/616e0302df19e2bfc3b88494faa6d973885412bf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2345?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/2345?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=)
 | 81.4815% | [1 Missing and 4 partials :warning: 
](https://app.codecov.io/gh/apache/groovy/pull/2345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/2345/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/2345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #2345        +/-   ##
   ==================================================
   + Coverage     66.9911%   66.9926%   +0.0015%     
   - Complexity      29341      29345         +4     
   ==================================================
     Files            1382       1382                
     Lines          116602     116589        -13     
     Branches        20432      20431         -1     
   ==================================================
   - Hits            78113      78106         -7     
   + Misses          32058      32052         -6     
     Partials         6431       6431                
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2345?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/2345?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=)
 | `78.5036% <81.4815%> (-0.0995%)` | :arrow_down: |
   
   ... and [3 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/2345/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> Extending a class via its superclass' metaclass changes method visibility 
> rules
> -------------------------------------------------------------------------------
>
>                 Key: GROOVY-10198
>                 URL: https://issues.apache.org/jira/browse/GROOVY-10198
>             Project: Groovy
>          Issue Type: Bug
>          Components: groovy-runtime
>    Affects Versions: 2.4.15
>            Reporter: L
>            Assignee: Eric Milles
>            Priority: Major
>         Attachments: Test1.groovy
>
>
> Private fields/methods of a superclass are not accessible in groovy, see 
> GROOVY-3142
> But if some superclasses in the class hierarchy is extended via its 
> metaclass, private methods become visible.
> This happens in all the latest 2.X (2.4.21), 3.X (3.0.8) and 4.X 
> (4.0.0-alpha-3) versions.
>  
> Attached is a simple groovy script that demonstrates it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to