jrepp commented on PR #2346:
URL: https://github.com/apache/groovy/pull/2346#issuecomment-3592166046

   > I have left some single line comments but the main comment is that while 
we build during releases with JDK17+, we still run the build for JDKs 8 through 
16 for testing purposes: 
https://github.com/apache/groovy/blob/GROOVY_4_0_X/.github/workflows/groovy-build-test.yml#L31
 
https://github.com/apache/groovy/blob/GROOVY_4_0_X/.github/workflows/groovy-build-test.yml#L57
   > 
   > We'd need to change at least that part of the build to use tool chains 
before we could upgrade GROOVY_4_0_X to Gradle 9.
   
   Thank you @paulk-asert. Happy to address the comments and I can look into 
the tool chains support. This is a side project, I'm working on TinkerPop and 
addressing this underlying dependency first. I am a groovy fan so it's nice to 
find a small corner I might be able to contribute some support.
   
   Just as a gut check, is this idea to add Java 25 to the build support matrix 
valuable enough for me to chase down the remaining issues?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to