sbglasius commented on code in PR #2350:
URL: https://github.com/apache/groovy/pull/2350#discussion_r2580059901
##########
src/test/groovy/org/codehaus/groovy/transform/CanonicalComponentsTransformTest.groovy:
##########
@@ -564,7 +564,7 @@ class CanonicalComponentsTransformTest extends
GroovyShellTestCase {
// GROOVY-4570
void testToStringForEnums() {
- assert Color.PURPLE.toString() ==
'org.codehaus.groovy.transform.Color(r:255, g:0, b:255)'
+ assert Color.PURPLE.toString() == 'PURPLE(r:255, g:0, b:255)'
Review Comment:
I think that we lose context here. It becomes hard to see, what `PURPLE`
refers to.
IMO I think it would be better to output `Color.PURPLE(r:255, g:0, b:255)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
