jonnybot0 commented on PR #2374: URL: https://github.com/apache/groovy/pull/2374#issuecomment-3825526977
I'm also well outside my expertise here, but so long as we're doing this, I'd be curious to see how this runs against the performance tests we have, compared to baseline. https://ci-builds.apache.org/job/Groovy/job/Groovy%204%20performance%20tests/ has a Jenkins build that runs these. That's no good for running against a community repository, but perhaps we could push this up to a different branch and run it. Little outside my usual wheelhouse, so I'd like the nod from @paulk-asert, @blackdrag, or someone else on the PMC before I just run it willy-nilly. I tried running `./gradlew :performance:performanceTests` on my local machine with Java 17 on this branch: ``` Groovy 4.0.7 Average 376.26ms ± 64.42ms Groovy current Average 376.87ms ± 63.75ms (0.16% slower) Groovy 3.0.14 Average 443.74ms ± 131.81ms (17.93% slower) Groovy 2.5.20 Average 451.40999999999997ms ± 138.82ms (19.97% slower) ``` That seems comparable, so my assumption is this hasn't hurt the most basic performance measures we do. Main reason I'd want CI confirmation is to make sure it wasn't a quirk of my machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
