[
https://issues.apache.org/jira/browse/GROOVY-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058737#comment-18058737
] ASF GitHub Bot commented on GROOVY-11858: ----------------------------------------- codecov-commenter commented on PR #2379: URL: https://github.com/apache/groovy/pull/2379#issuecomment-3904786647 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2379?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `63.63636%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.7223%. Comparing base ([`9b4ec31`](https://app.codecov.io/gh/apache/groovy/commit/9b4ec311df38c915fdaa36f8b5c37585cc90762c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a688de6`](https://app.codecov.io/gh/apache/groovy/commit/a688de615839e5171e023855480d057531fedd19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2379?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...aus/groovy/runtime/metaclass/ClosureMetaClass.java](https://app.codecov.io/gh/apache/groovy/pull/2379?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2Fmetaclass%2FClosureMetaClass.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvbWV0YWNsYXNzL0Nsb3N1cmVNZXRhQ2xhc3MuamF2YQ==) | 63.6364% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2379?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2379?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2379 +/- ## ================================================== + Coverage 66.7154% 66.7223% +0.0069% - Complexity 29846 29854 +8 ================================================== Files 1382 1382 Lines 116180 116189 +9 Branches 20491 20497 +6 ================================================== + Hits 77510 77524 +14 + Misses 32323 32318 -5 Partials 6347 6347 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2379?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/2379?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=) | `77.7716% <ø> (ø)` | | | [...aus/groovy/runtime/metaclass/ClosureMetaClass.java](https://app.codecov.io/gh/apache/groovy/pull/2379?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2Fmetaclass%2FClosureMetaClass.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvbWV0YWNsYXNzL0Nsb3N1cmVNZXRhQ2xhc3MuamF2YQ==) | `72.6027% <63.6364%> (-0.1888%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2379/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Splitting string inside tap closure throws NullPointerException > --------------------------------------------------------------- > > Key: GROOVY-11858 > URL: https://issues.apache.org/jira/browse/GROOVY-11858 > Project: Groovy > Issue Type: Bug > Affects Versions: 5.0.4 > Reporter: Evan Shaw > Assignee: Eric Milles > Priority: Major > > This code throws an exception: > {code:groovy} > 'a b c'.tap { println(split()) } > {code} > The exception message: > {code} > NullPointerException: Cannot invoke > "groovy.lang.Closure.getMaximumNumberOfParameters()" because "wrapped" is null > {code} > If I pass an argument to split, it works as expected: > {code:groovy} > 'a b c'.tap { println(split(' ')) } > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
