[jira] [Commented] (GROOVY-12022) deprecate IndyStaticTypesMultiTypeDispatcher

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/GROOVY-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18083054#comment-18083054
 ] 

ASF GitHub Bot commented on GROOVY-12022:
-----------------------------------------

sonarqubecloud[bot] commented on PR #2546:
URL: https://github.com/apache/groovy/pull/2546#issuecomment-4525017085

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_groovy&pullRequest=2546) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_groovy&pullRequest=2546&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_groovy&pullRequest=2546&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_groovy&pullRequest=2546&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [100.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_groovy&pullRequest=2546&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_groovy&pullRequest=2546&metric=new_duplicated_lines_density&view=list)
  
     
   <!

> deprecate IndyStaticTypesMultiTypeDispatcher
> --------------------------------------------
>
>                 Key: GROOVY-12022
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12022
>             Project: Groovy
>          Issue Type: Bug
>            Reporter: Jochen Theodorou
>            Assignee: Jochen Theodorou
>            Priority: Minor
>
> In IndyStaticTypesMultiTypeDispatcher.java (lines 95-99), the get and set 
> names are swapped for float and boolean arrays (using name "get" for a 
> descriptor that returns void and takes a value).
>  The code works because the IndyInterface.staticArrayAccess bootstrap method 
> ignores the name parameter and uses the parameter count of the MethodType 
> instead.
> But in general I see no reason to use invokedynamic here. The non-indy code 
> uses BytecodeInterface8 to access the specific code paths for array access 
> and should be faster than the indy version since it is a "simple" static 
> method invocation. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)