[jira] [Commented] (GROOVY-11935) Set invokedynamic call site target immediately to enable earlier JIT inlining

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/GROOVY-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18083122#comment-18083122
 ] 

ASF GitHub Bot commented on GROOVY-11935:
-----------------------------------------

testlens-app[bot] commented on PR #2562:
URL: https://github.com/apache/groovy/pull/2562#issuecomment-4527503777

   ## 🚨 TestLens detected 1 failed test 🚨
   
   Here is what you can do:
   
   1) Inspect the test failures carefully.
   2) If you are convinced that some of the tests are flaky, you can mute them 
below.
   3) Finally, trigger a rerun by checking the rerun checkbox.
   
   ### Test Summary
   
   | Check | Project/Task | Test | Runs |
   |---|---|---|---|
   | [Build and test / lts \(17, 
ubuntu-latest\)](https://github.com/apache/groovy/actions/runs/26352784017/job/77573864836?pr=2562)
 | :groovy-groovysh:test | HelpCommandTest > helpListsKnownCommands\(\) | ❌ |
   
   🏷️ Commit: 5af418de2456619e55ab8b4b92d68f1087d13458
   ▶️ Tests:  19819 executed
   🟡 Checks: 4/28 completed
   
   ### Test Failures
   
   <details>
   
   <summary><strong>HelpCommandTest > helpListsKnownCommands()</strong> 
(:groovy-groovysh:test in <a 
href="https://github.com/apache/groovy/actions/runs/26352784017/job/77573864836?pr=2562";>Build
 and test / lts (17, ubuntu-latest)</a>)</summary>
   
   ```
   Assertion failed: 
   
   assert !out.empty
          ||   |
          |''  true
          false
   
        at 
org.codehaus.groovy.runtime.InvokerHelper.createAssertError(InvokerHelper.java:400)
        at 
org.apache.groovy.groovysh.commands.HelpCommandTest.helpListsKnownCommands(HelpCommandTest.groovy:39)
   ```
   
   </details>
   
   ### Muted Tests
   > [!NOTE]
   > Checks are currently running using the configuration below.
   
   Select tests to mute in this pull request:
   
   🔲 HelpCommandTest > helpListsKnownCommands\(\) <!

> Set invokedynamic call site target immediately to enable earlier JIT inlining
> -----------------------------------------------------------------------------
>
>                 Key: GROOVY-11935
>                 URL: https://issues.apache.org/jira/browse/GROOVY-11935
>             Project: Groovy
>          Issue Type: Improvement
>            Reporter: Daniel Sun
>            Assignee: Daniel Sun
>            Priority: Major
>             Fix For: 6.0.0-alpha-1
>
>
> When a invokedynamic call resolves to static call, the call site currently 
> waits for normal PIC warmup(i.e. wait for the 1,000-hit threshold) before 
> setting the optimized target. This delays JIT inlining for static calls such 
> as {{{}A.foo(){}}}. Set invokedynamic call site target immediately to enable 
> earlier JIT inlining.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)