[
https://issues.apache.org/jira/browse/GROOVY-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18084688#comment-18084688
]
ASF GitHub Bot commented on GROOVY-12054:
-----------------------------------------
codecov-commenter commented on PR #2578:
URL: https://github.com/apache/groovy/pull/2578#issuecomment-4586260633
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2578?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `56.97674%` with `37 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 68.1716%. Comparing base
([`9a560a6`](https://app.codecov.io/gh/apache/groovy/commit/9a560a649487555ca6d58c7953d2d5290be3fee8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`91c6004`](https://app.codecov.io/gh/apache/groovy/commit/91c600499a846b390af2ef3f8d5dbbfd665ff38a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2578?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[.../codehaus/groovy/runtime/DefaultGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2578?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FDefaultGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRGVmYXVsdEdyb292eU1ldGhvZHMuamF2YQ==)
| 56.9767% | [35 Missing and 2 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2578 +/- ##
==================================================
- Coverage 68.1789% 68.1716% -0.0073%
- Complexity 33164 33189 +25
==================================================
Files 1511 1511
Lines 126237 126318 +81
Branches 22897 22914 +17
==================================================
+ Hits 86067 86113 +46
- Misses 32529 32565 +36
+ Partials 7641 7640 -1
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2578?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[.../codehaus/groovy/runtime/DefaultGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2578?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FDefaultGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRGVmYXVsdEdyb292eU1ldGhvZHMuamF2YQ==)
| `74.6598% <56.9767%> (-0.4238%)` | :arrow_down: |
... and [8 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2578/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> A preliminary set of "fat-free" DGM methods
> -------------------------------------------
>
> Key: GROOVY-12054
> URL: https://issues.apache.org/jira/browse/GROOVY-12054
> Project: Groovy
> Issue Type: Sub-task
> Reporter: Paul King
> Assignee: Paul King
> Priority: Major
>
> h2. Overview
> Continues the "fat-free lambda" work from GROOVY-12034 by adding
> {{java.util.function}}\-typed overloads to the most-used higher-order DGM
> methods. Pairs with the {{org.apache.groovy.util.Lambdas}} / {{Closures}}
> {{curryWith}} helpers landed under GROOVY-12043 — callers can pass
> {{Predicate}}/{{Function}}/{{Consumer}} (and the Bi-* / ObjInt-* SAMs where
> shape demands) directly without {{Closure}} wrapping, and compose with
> {{Lambdas.curryWith(...)}} for the right-curry pattern that motivated
> GROOVY-12034.
> h2. Scope
> Prime candidates for direct use or use in combination with {{curryWith}}:
> * {{each(Iterable<T>, Consumer<? super T>)}} -> {{Iterable<T>}}
> * {{findAll(Iterable<T>, Predicate<? super T>)}} -> {{List<T>}}
> * {{find(Iterable<T>, Predicate<? super T>)}} -> {{T}}
> * {{any(Iterable<T>, Predicate<? super T>)}} -> {{boolean}}
> * {{every(Iterable<T>, Predicate<? super T>)}} -> {{boolean}}
> * {{inject(Iterable<T>, BinaryOperator<T>)}} -> {{T}} (unseeded)
> * {{inject(Iterable<E>, U initial, BiFunction<U, ? super E, U>)}} -> {{U}}
> (seeded)
> * {{collect(Iterable<E>, C collector, Function<? super E, ? extends T>)}} ->
> {{C}} (collector variant; the basic form {{collect(Iterable<E>, Function)}}
> already landed under GROOVY-12034)
> * {{groupBy(Iterable<T>, Function<? super T, ? extends K>)}} -> {{Map<K,
> List<T>>}}
> * {{eachWithIndex(Iterable<T>, ObjIntConsumer<? super T>)}} ->
> {{Iterable<T>}} (uses {{ObjIntConsumer}} to avoid per-element {{Integer}}
> autoboxing)
> * {{collectEntries(Iterable<E>, Function<? super E, ? extends Map.Entry<K,
> V>>)}} -> {{Map<K, V>}} (single-function form; the two-function form already
> exists)
> * {{collect(Map<K, V>, BiFunction<? super K, ? super V, ? extends T>)}} ->
> {{List<T>}}
> * {{findAll(Map<K, V>, BiPredicate<? super K, ? super V>)}} -> {{Map<K, V>}}
> * {{collect(Iterator<E>, Function<? super E, ? extends T>)}} -> {{List<T>}}
> * {{findAll(Iterator<T>, Predicate<? super T>)}} -> {{List<T>}} — new; the
> existing {{Closure}} family has no {{findAll(Iterator, Closure)}}, so this is
> a fat-free-only addition for symmetry with {{collect(Iterator, Function)}}
> * {{findAll(Set<T>, Predicate<? super T>)}} -> {{Set<T>}} — the one method
> where preserving the {{Set}} self-type matters for downstream membership
> semantics
> Total: 16 new overloads.
> Prime candidates for explicit "With" style methods:
> * {{findAll(Iterable, BiPredicate<? super T, ? super P>, P)}} -> {{List}}
> * {{collect(Iterable, BiFunction<? super E, ? super P, ? extends R>, P)}} ->
> {{List}}
> Total: 2 new overloads.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
