[
https://issues.apache.org/jira/browse/GROOVY-12092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18089392#comment-18089392
] ASF GitHub Bot commented on GROOVY-12092: ----------------------------------------- codecov-commenter commented on PR #2614: URL: https://github.com/apache/groovy/pull/2614#issuecomment-4719497248 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2614?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `30.76923%` with `9 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.4487%. Comparing base ([`1411509`](https://app.codecov.io/gh/apache/groovy/commit/141150926387f5f1739369638d614a74275f2821?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e71956`](https://app.codecov.io/gh/apache/groovy/commit/4e71956438a9b68869639108afd6ec996b907f8b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2614?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...codehaus/groovy/vmplugin/v8/CacheableCallSite.java](https://app.codecov.io/gh/apache/groovy/pull/2614?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv8%2FCacheableCallSite.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0NhY2hlYWJsZUNhbGxTaXRlLmphdmE=) | 30.7692% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2614?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2614?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2614 +/- ## ================================================== - Coverage 68.4522% 68.4487% -0.0035% - Complexity 33500 33503 +3 ================================================== Files 1518 1518 Lines 127096 127101 +5 Branches 23063 23064 +1 ================================================== - Hits 87000 86999 -1 - Misses 32371 32374 +3 - Partials 7725 7728 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2614?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...codehaus/groovy/vmplugin/v8/CacheableCallSite.java](https://app.codecov.io/gh/apache/groovy/pull/2614?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv8%2FCacheableCallSite.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0NhY2hlYWJsZUNhbGxTaXRlLmphdmE=) | `74.2857% <30.7692%> (-4.1758%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2614/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Allow a "groovy.indy.callsite.cache.cleaner.thread" flag to turn off the > PIC-Cleaner thread > ------------------------------------------------------------------------------------------- > > Key: GROOVY-12092 > URL: https://issues.apache.org/jira/browse/GROOVY-12092 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > The default would be true, same as current behavior. > If using a deadlock detection library, e.g. during testing, you could switch > it off and the PIC-Cleaner thread won't be detected as a false positive > deadlocked thread. -- This message was sent by Atlassian Jira (v8.20.10#820010)
