[ 
https://issues.apache.org/jira/browse/GROOVY-12119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18092628#comment-18092628
 ] 

ASF GitHub Bot commented on GROOVY-12119:
-----------------------------------------

codecov-commenter commented on PR #2649:
URL: https://github.com/apache/groovy/pull/2649#issuecomment-4843397778

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2649?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :x: Patch coverage is `66.66667%` with `3 lines` in your changes missing 
coverage. Please review.
   :white_check_mark: Project coverage is 68.5644%. Comparing base 
([`0eca85d`](https://app.codecov.io/gh/apache/groovy/commit/0eca85d0424f6f05e504586fc7cc72999df01762?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`e9725bd`](https://app.codecov.io/gh/apache/groovy/commit/e9725bd22880e5f6f3e4cbb11b031b7e260be171?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 3 commits behind head on master.
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2649?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...roovy/jmx/builder/JmxServerConnectorFactory.groovy](https://app.codecov.io/gh/apache/groovy/pull/2649?src=pr&el=tree&filepath=subprojects%2Fgroovy-jmx%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fjmx%2Fbuilder%2FJmxServerConnectorFactory.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpteC9zcmMvbWFpbi9ncm9vdnkvZ3Jvb3Z5L2pteC9idWlsZGVyL0pteFNlcnZlckNvbm5lY3RvckZhY3RvcnkuZ3Jvb3Z5)
 | 66.6667% | [1 Missing and 2 partials :warning: 
](https://app.codecov.io/gh/apache/groovy/pull/2649?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/2649/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/2649?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #2649        +/-   ##
   ==================================================
   + Coverage     68.5407%   68.5644%   +0.0237%     
   - Complexity      33742      33750         +8     
   ==================================================
     Files            1523       1523                
     Lines          127940     127944         +4     
     Branches        23254      23254                
   ==================================================
   + Hits            87691      87724        +33     
   + Misses          32463      32439        -24     
   + Partials         7786       7781         -5     
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2649?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[...roovy/jmx/builder/JmxServerConnectorFactory.groovy](https://app.codecov.io/gh/apache/groovy/pull/2649?src=pr&el=tree&filepath=subprojects%2Fgroovy-jmx%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fjmx%2Fbuilder%2FJmxServerConnectorFactory.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpteC9zcmMvbWFpbi9ncm9vdnkvZ3Jvb3Z5L2pteC9idWlsZGVyL0pteFNlcnZlckNvbm5lY3RvckZhY3RvcnkuZ3Jvb3Z5)
 | `56.0000% <66.6667%> (+30.4186%)` | :arrow_up: |
   
   ... and [8 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/2649/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> JmxBuilder: connector environment map is discarded
> --------------------------------------------------
>
>                 Key: GROOVY-12119
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12119
>             Project: Groovy
>          Issue Type: Bug
>          Components: groovy-jmx
>    Affects Versions: 6.0.0-alpha-1
>            Reporter: Paul King
>            Assignee: Paul King
>            Priority: Major
>             Fix For: 6.0.0-alpha-2
>
>
> The config map wasn't returning which hid a typo in an SSL-related property. 
> This issue fixes both parts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to