[
https://issues.apache.org/jira/browse/GROOVY-12128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18093750#comment-18093750
] ASF GitHub Bot commented on GROOVY-12128: ----------------------------------------- codecov-commenter commented on PR #2665: URL: https://github.com/apache/groovy/pull/2665#issuecomment-4884816374 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2665?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `63.63636%` with `28 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.5636%. Comparing base ([`faee99b`](https://app.codecov.io/gh/apache/groovy/commit/faee99b83998b6557bef2bda9968b9eb5dc0b502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d1a34ea`](https://app.codecov.io/gh/apache/groovy/commit/d1a34ea3c4dc96613c2a4a7bd4ab2cf9dc01567d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2665?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...vy/contracts/ast/LoopVariantASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2665?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fast%2FLoopVariantASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9hc3QvTG9vcFZhcmlhbnRBU1RUcmFuc2Zvcm1hdGlvbi5qYXZh) | 61.7021% | [16 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../contracts/ast/LoopInvariantASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2665?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fast%2FLoopInvariantASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9hc3QvTG9vcEludmFyaWFudEFTVFRyYW5zZm9ybWF0aW9uLmphdmE=) | 50.0000% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/groovy/contracts/ast/LoopContractSupport.java](https://app.codecov.io/gh/apache/groovy/pull/2665?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fast%2FLoopContractSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9hc3QvTG9vcENvbnRyYWN0U3VwcG9ydC5qYXZh) | 78.5714% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/groovy/contracts/VariantSupport.java](https://app.codecov.io/gh/apache/groovy/pull/2665?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2FVariantSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9WYXJpYW50U3VwcG9ydC5qYXZh) | 75.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2665 +/- ## ================================================== - Coverage 68.5706% 68.5636% -0.0069% - Complexity 33808 33813 +5 ================================================== Files 1524 1524 Lines 128141 128205 +64 Branches 23292 23299 +7 ================================================== + Hits 87867 87902 +35 - Misses 32472 32502 +30 + Partials 7802 7801 -1 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2665?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/groovy/contracts/VariantSupport.java](https://app.codecov.io/gh/apache/groovy/pull/2665?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2FVariantSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9WYXJpYW50U3VwcG9ydC5qYXZh) | `72.7273% <75.0000%> (+0.3135%)` | :arrow_up: | | [...ache/groovy/contracts/ast/LoopContractSupport.java](https://app.codecov.io/gh/apache/groovy/pull/2665?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fast%2FLoopContractSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9hc3QvTG9vcENvbnRyYWN0U3VwcG9ydC5qYXZh) | `61.4035% <78.5714%> (+5.5896%)` | :arrow_up: | | [.../contracts/ast/LoopInvariantASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2665?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fast%2FLoopInvariantASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9hc3QvTG9vcEludmFyaWFudEFTVFRyYW5zZm9ybWF0aW9uLmphdmE=) | `57.8947% <50.0000%> (-5.0682%)` | :arrow_down: | | [...vy/contracts/ast/LoopVariantASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2665?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fast%2FLoopVariantASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9hc3QvTG9vcFZhcmlhbnRBU1RUcmFuc2Zvcm1hdGlvbi5qYXZh) | `50.5618% <61.7021%> (-17.9567%)` | :arrow_down: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2665/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > loop contract checks fire at points that disagree with loop semantics > --------------------------------------------------------------------- > > Key: GROOVY-12128 > URL: https://issues.apache.org/jira/browse/GROOVY-12128 > Project: Groovy > Issue Type: Improvement > Components: groovy-contracts > Reporter: Paul King > Assignee: Paul King > Priority: Major > Fix For: 6.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
