[
https://issues.apache.org/jira/browse/GROOVY-12151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18095647#comment-18095647
] ASF GitHub Bot commented on GROOVY-12151: ----------------------------------------- codecov-commenter commented on PR #2692: URL: https://github.com/apache/groovy/pull/2692#issuecomment-4948985108 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2692?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `74.59016%` with `93 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 69.1226%. Comparing base ([`f3e3bff`](https://app.codecov.io/gh/apache/groovy/commit/f3e3bffa427b293e489397f65c70b145e6023f31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11dbdaf`](https://app.codecov.io/gh/apache/groovy/commit/11dbdaf14d086b118d67007bc2a99f2cb1ffdccf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 7 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2692?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ava/org/codehaus/groovy/runtime/PackedClosure.java](https://app.codecov.io/gh/apache/groovy/pull/2692?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FPackedClosure.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvUGFja2VkQ2xvc3VyZS5qYXZh) | 38.7500% | [37 Missing and 12 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/codehaus/groovy/classgen/asm/ClosureWriter.java](https://app.codecov.io/gh/apache/groovy/pull/2692?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2FClosureWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9DbG9zdXJlV3JpdGVyLmphdmE=) | 83.7736% | [17 Missing and 26 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/codehaus/groovy/ast/ClassNode.java](https://app.codecov.io/gh/apache/groovy/pull/2692?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2FClassNode.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC9DbGFzc05vZGUuamF2YQ==) | 90.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2692 +/- ## ================================================== + Coverage 69.0875% 69.1226% +0.0351% - Complexity 34165 34315 +150 ================================================== Files 1536 1540 +4 Lines 129048 129658 +610 Branches 23403 23559 +156 ================================================== + Hits 89156 89623 +467 - Misses 31909 31988 +79 - Partials 7983 8047 +64 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2692?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [src/main/java/groovy/transform/PackMode.java](https://app.codecov.io/gh/apache/groovy/pull/2692?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Ftransform%2FPackMode.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvdHJhbnNmb3JtL1BhY2tNb2RlLmphdmE=) | `100.0000% <100.0000%> (ø)` | | | [...org/codehaus/groovy/classgen/asm/PackStrategy.java](https://app.codecov.io/gh/apache/groovy/pull/2692?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2FPackStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9QYWNrU3RyYXRlZ3kuamF2YQ==) | `100.0000% <100.0000%> (ø)` | | | [...oovy/classgen/asm/sc/StaticTypesClosureWriter.java](https://app.codecov.io/gh/apache/groovy/pull/2692?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2Fsc%2FStaticTypesClosureWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9zYy9TdGF0aWNUeXBlc0Nsb3N1cmVXcml0ZXIuamF2YQ==) | `88.5246% <100.0000%> (+0.1913%)` | :arrow_up: | | [...c/main/java/org/codehaus/groovy/ast/ClassNode.java](https://app.codecov.io/gh/apache/groovy/pull/2692?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2FClassNode.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC9DbGFzc05vZGUuamF2YQ==) | `87.5740% <90.0000%> (ø)` | | | [...rg/codehaus/groovy/classgen/asm/ClosureWriter.java](https://app.codecov.io/gh/apache/groovy/pull/2692?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2FClosureWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9DbG9zdXJlV3JpdGVyLmphdmE=) | `87.6310% <83.7736%> (-4.8218%)` | :arrow_down: | | [...ava/org/codehaus/groovy/runtime/PackedClosure.java](https://app.codecov.io/gh/apache/groovy/pull/2692?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FPackedClosure.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvUGFja2VkQ2xvc3VyZS5qYXZh) | `38.7500% <38.7500%> (ø)` | | ... and [27 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2692/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > hoist eligible closure bodies to a shared adapter @PackedClosures/flag > (GEP-27 S1) > ---------------------------------------------------------------------------------- > > Key: GROOVY-12151 > URL: https://issues.apache.org/jira/browse/GROOVY-12151 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
