daniellansun commented on PR #2736: URL: https://github.com/apache/groovy/pull/2736#issuecomment-5082573905
@paulk-asert Thanks for your review. | Point | Action | |-------|--------| | Array fan-out hole (`Object[]` final short-circuit) | Fixed via `ClassHierarchyIndex` (full JLS array lattice) + single invalidate path; tests for `Object[]` / interface arrays / multi-dim | | Legacy `switchPoint` lost lock | Restored `synchronized (IndyInterface.class)` | | `switchPoint` semantics / javadoc over-claim | Docs: bulk-only rotation; misses per-class MC; `@Deprecated(since="6.0.0", forRemoval=false)` | | `incVersion()` no longer global flush | Documented + test; bulk callers → `invalidateCallSites()` / `invalidateCategory()` | | Scalability O(N×M) | **Shipped** weak ancestor→descendant index; typed MC invalidation is O(subtypes). Category still full walk (cheap no-op detach) | | Sonar S1186 / S6355 / S3077 | Empty-ctor comment; deprecate metadata; sync rotation | | `invokeColdReflective` | Documented as intentional cold-tier change (not pure scoping) | | Perf Alert bot | False alarm: 1841→2857 ops/ms is **faster** (throughput misread as latency) | Happy to adjust if anything still looks off. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
