[
https://issues.apache.org/jira/browse/GROOVY-12226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101577#comment-18101577
] ASF GitHub Bot commented on GROOVY-12226: ----------------------------------------- codecov-commenter commented on PR #2764: URL: https://github.com/apache/groovy/pull/2764#issuecomment-5174857347 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2764?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `75.00000%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.2530%. Comparing base ([`1863331`](https://app.codecov.io/gh/apache/groovy/commit/1863331a9ae5a168a7b087eec35225f5c8e8902f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aa18bab`](https://app.codecov.io/gh/apache/groovy/commit/aa18bab0406ea9ee0a3bca9cbbcfb1dff9c25efd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2764?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...s/groovy/classgen/InnerClassCompletionVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2764?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FInnerClassCompletionVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL0lubmVyQ2xhc3NDb21wbGV0aW9uVmlzaXRvci5qYXZh) | 75.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2764?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2764?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## GROOVY_5_1_X #2764 +/- ## ====================================================== - Coverage 67.2538% 67.2530% -0.0009% - Complexity 29598 29600 +2 ====================================================== Files 1382 1382 Lines 117061 117064 +3 Branches 20581 20583 +2 ====================================================== + Hits 78728 78729 +1 - Misses 31788 31790 +2 Partials 6545 6545 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2764?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...s/groovy/classgen/InnerClassCompletionVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2764?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FInnerClassCompletionVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL0lubmVyQ2xhc3NDb21wbGV0aW9uVmlzaXRvci5qYXZh) | `90.6863% <75.0000%> (-0.3585%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2764/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Double-nested non-static class in trait calling outer method compiles, but > fails at runtime > ------------------------------------------------------------------------------------------- > > Key: GROOVY-12226 > URL: https://issues.apache.org/jira/browse/GROOVY-12226 > Project: Groovy > Issue Type: Bug > Components: Compiler > Affects Versions: 5.0.8 > Reporter: Octavia Togami > Priority: Major > > The following code works in 4.0.33, but fails in 5.0.8: > {code:groovy} > trait T { > static class Outer { > def outerMethod() { 'p' } > class Inner { def callOuter() { outerMethod() } } > def viaInner() { new Inner().callOuter() } > } > } > assert new T.Outer().viaInner() == 'p' > {code} > The failure is: > {code:sh} > java.lang.NoSuchMethodError: 'java.lang.Object > T$Outer.this$dist$invoke$1(java.lang.String, java.lang.Object)' > at T$Outer$Inner.methodMissing(v6_named.groovy) > at T$Outer$Inner.callOuter(v6_named.groovy:4) > {code} > This is because the compiler tries to generate a call to > {{T$Outer.this$dist$invoke$1}} in {{callOuter}}, but does not generate that > method in {{T$Outer}}, unlike Groovy 4. It should either produce a proper > compiler error, or generate the bridge method. > This was reduced from real code in Gradle: > https://github.com/gradle/gradle/blob/2e04b0a02ba788075b2be3614f9fc0562ecfaf9d/platforms/native/language-native/src/testFixtures/groovy/org/gradle/language/LanguageTaskNames.groovy#L121 -- This message was sent by Atlassian Jira (v8.20.10#820010)
