[
https://issues.apache.org/jira/browse/GROOVY-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18105414#comment-18105414
] ASF GitHub Bot commented on GROOVY-12265: ----------------------------------------- codecov-commenter commented on PR #2802: URL: https://github.com/apache/groovy/pull/2802#issuecomment-5322872838 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2802?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `23 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 70.1528%. Comparing base ([`5f56279`](https://app.codecov.io/gh/apache/groovy/commit/5f562793bd5b7f7adb4792e41dcd0385b5452ac9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`605d09b`](https://app.codecov.io/gh/apache/groovy/commit/605d09b0bd698854735de2cb849f6b14f887f37f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2802?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ovy/grape/maven/GrapeChecksumPolicyProvider.groovy](https://app.codecov.io/gh/apache/groovy/pull/2802?src=pr&el=tree&filepath=subprojects%2Fgroovy-grape-maven%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fgrape%2Fmaven%2FGrapeChecksumPolicyProvider.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyYXBlLW1hdmVuL3NyYy9tYWluL2dyb292eS9ncm9vdnkvZ3JhcGUvbWF2ZW4vR3JhcGVDaGVja3N1bVBvbGljeVByb3ZpZGVyLmdyb292eQ==) | 0.0000% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/groovy/groovy/grape/maven/GrapeMaven.groovy](https://app.codecov.io/gh/apache/groovy/pull/2802?src=pr&el=tree&filepath=subprojects%2Fgroovy-grape-maven%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fgrape%2Fmaven%2FGrapeMaven.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyYXBlLW1hdmVuL3NyYy9tYWluL2dyb292eS9ncm9vdnkvZ3JhcGUvbWF2ZW4vR3JhcGVNYXZlbi5ncm9vdnk=) | 0.0000% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2802 +/- ## ================================================== + Coverage 70.1516% 70.1528% +0.0012% - Complexity 35828 35834 +6 ================================================== Files 1562 1563 +1 Lines 132523 132545 +22 Branches 24379 24380 +1 ================================================== + Hits 92967 92984 +17 - Misses 31140 31153 +13 + Partials 8416 8408 -8 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2802?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...c/main/groovy/groovy/grape/maven/GrapeMaven.groovy](https://app.codecov.io/gh/apache/groovy/pull/2802?src=pr&el=tree&filepath=subprojects%2Fgroovy-grape-maven%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fgrape%2Fmaven%2FGrapeMaven.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyYXBlLW1hdmVuL3NyYy9tYWluL2dyb292eS9ncm9vdnkvZ3JhcGUvbWF2ZW4vR3JhcGVNYXZlbi5ncm9vdnk=) | `0.0000% <0.0000%> (ø)` | | | [...ovy/grape/maven/GrapeChecksumPolicyProvider.groovy](https://app.codecov.io/gh/apache/groovy/pull/2802?src=pr&el=tree&filepath=subprojects%2Fgroovy-grape-maven%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fgrape%2Fmaven%2FGrapeChecksumPolicyProvider.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyYXBlLW1hdmVuL3NyYy9tYWluL2dyb292eS9ncm9vdnkvZ3JhcGUvbWF2ZW4vR3JhcGVDaGVja3N1bVBvbGljeVByb3ZpZGVyLmdyb292eQ==) | `0.0000% <0.0000%> (ø)` | | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2802/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > GrapeMaven: fail resolution on checksum mismatch > ------------------------------------------------ > > Key: GROOVY-12265 > URL: https://issues.apache.org/jira/browse/GROOVY-12265 > Project: Groovy > Issue Type: Improvement > Components: Grape > Reporter: Paul King > Priority: Major > > The default of mismatch failing by default should be similar to Ivy. Maven > would also fail when no checksums are present whereas Ivy only fails for a > bad checksum. -- This message was sent by Atlassian Jira (v8.20.10#820010)
