github-advanced-security[bot] commented on code in PR #2834: URL: https://github.com/apache/groovy/pull/2834#discussion_r3888350210
########## src/main/java/org/apache/groovy/internal/util/ClassFiles.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.groovy.internal.util; + +import org.codehaus.groovy.ast.decompiled.AsmDecompiler; +import org.codehaus.groovy.ast.decompiled.ClassStub; + +import java.io.IOException; +import java.net.URL; + +/** + * Locates a {@code .class} resource and tests whether it decompiles to the + * requested binary name, using {@link AsmDecompiler#parseClass(URL)}. + * <p> + * {@link groovy.lang.GroovyClassLoader} and + * {@link org.codehaus.groovy.control.ClassNodeResolver} both use + * {@link #isBytecodeNameMatch} so the bytecode-name check is one comparison + * ({@link ClassStub#getClassName()}). {@link AsmDecompiler} caches stubs by + * URI, so an ASM-on resolve that later calls {@code loadClass} does not parse + * the same file twice. + * + * @since 6.0.0 + */ +public final class ClassFiles { + private ClassFiles() { + } + + /** + * Resource path of {@code binaryName}, e.g. {@code java.lang.String} to + * {@code java/lang/String.class}. + */ + public static String resourcePath(final String binaryName) { + return binaryName.replace('.', '/') + ".class"; + } + + /** + * {@code loader.getResource} of {@link #resourcePath(String)}. + */ + public static URL findResource(final ClassLoader loader, final String binaryName) { + return loader.getResource(resourcePath(binaryName)); Review Comment: ## CodeQL / Uncontrolled data used in path expression This path depends on a [user-provided value](1). [Show more details](https://github.com/apache/groovy/security/code-scanning/277) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
