[
https://issues.apache.org/jira/browse/GROOVY-12322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18109684#comment-18109684
]
ASF GitHub Bot commented on GROOVY-12322:
-----------------------------------------
codecov-commenter commented on PR #2848:
URL: https://github.com/apache/groovy/pull/2848#issuecomment-5469269550
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2848?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 70.6992%. Comparing base
([`0b7ac39`](https://app.codecov.io/gh/apache/groovy/commit/0b7ac391f36803602507533ab688388129dbebf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`431f1da`](https://app.codecov.io/gh/apache/groovy/commit/431f1dae4a38f13cd8c196e4347e50c462e7e970?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2848?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2848 +/- ##
==================================================
+ Coverage 70.6977% 70.6992% +0.0015%
- Complexity 36613 36619 +6
==================================================
Files 1571 1571
Lines 134085 134092 +7
Branches 24727 24729 +2
==================================================
+ Hits 94795 94802 +7
- Misses 30775 30776 +1
+ Partials 8515 8514 -1
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2848?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[.../apache/groovy/parser/antlr4/GroovydocManager.java](https://app.codecov.io/gh/apache/groovy/pull/2848?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FGroovydocManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0dyb292eWRvY01hbmFnZXIuamF2YQ==)
| `80.0000% <100.0000%> (-2.0896%)` | :arrow_down: |
... and [4 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2848/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Inline the nls parser rule
> --------------------------
>
> Key: GROOVY-12322
> URL: https://issues.apache.org/jira/browse/GROOVY-12322
> Project: Groovy
> Issue Type: Improvement
> Reporter: Daniel Sun
> Priority: Major
>
> h3. Motivation
> {{GroovyParser.g4}} used a shared helper for optional newlines:
> {noformat}
> nls : NL* ;
> sep : (NL | SEMI)+ ;
> {noformat}
> Because {{sep}} can start with {{NL}}, {{FOLLOW(nls)}} contains {{NL}}. The
> star inside {{nls}} is therefore not LL(1) at the rule level: generated
> {{nls()}} always uses adaptivePredict, even at call sites where a simple
> {{while (LA(1)==NL)}} would be correct. The rule also allocates a
> {{NlsContext}} for every invocation, including the empty match.
> {{classOrInterfaceModifiersOpt}} already inlined {{NL*}} for this reason,
> with a comment not to put {{nls}} back.
> Same class of prediction-cost reduction as GROOVY-12173, applied to newline
> handling.
> h3. Changes
> * Delete the {{nls}} rule and write {{NL*}} at every former call site, so
> each site has its own star decision.
> * Teach {{GroovydocManager}} to read {{NL}} terminals as direct children
> (comments are lexed as {{NL}}). {{sep}} still wraps mixed {{NL}} / {{SEMI}}
> sequences.
> h3. Compatibility
> * Language and AST for correct programs are unchanged.
> * Parse-tree shape changes: no {{NlsContext}}; empty matches produce no
> child. {{NlsContext}} is generated parser API, not a stability covenant.
> * No public API additions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
