[
https://issues.apache.org/jira/browse/GROOVY-12379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113094#comment-18113094
]
ASF GitHub Bot commented on GROOVY-12379:
-----------------------------------------
codecov-commenter commented on PR #2902:
URL: https://github.com/apache/groovy/pull/2902#issuecomment-5594551841
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2902?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `96.00000%` with `1 line` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 71.2106%. Comparing base
([`2290229`](https://app.codecov.io/gh/apache/groovy/commit/229022901454900a97368afcd55ba4e2571983bb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`a864d9f`](https://app.codecov.io/gh/apache/groovy/commit/a864d9fa46b826911c61116fae0abb311df82460?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2902?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...aus/groovy/tools/NativeImageMetadataGenerator.java](https://app.codecov.io/gh/apache/groovy/pull/2902?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2FNativeImageMetadataGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3Rvb2xzL05hdGl2ZUltYWdlTWV0YWRhdGFHZW5lcmF0b3IuamF2YQ==)
| 96.0000% | [1 Missing :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2902?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2902?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2902 +/- ##
==================================================
- Coverage 71.2116% 71.2106% -0.0010%
- Complexity 37622 37623 +1
==================================================
Files 1581 1581
Lines 136152 136175 +23
Branches 25291 25297 +6
==================================================
+ Hits 96956 96971 +15
- Misses 30462 30469 +7
- Partials 8734 8735 +1
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2902?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...aus/groovy/tools/NativeImageMetadataGenerator.java](https://app.codecov.io/gh/apache/groovy/pull/2902?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2FNativeImageMetadataGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3Rvb2xzL05hdGl2ZUltYWdlTWV0YWRhdGFHZW5lcmF0b3IuamF2YQ==)
| `90.4762% <96.0000%> (+1.1714%)` | :arrow_up: |
... and [10 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2902/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> native probe: cover groovy-nio, groovy-xml and groovy-json
> ----------------------------------------------------------
>
> Key: GROOVY-12379
> URL: https://issues.apache.org/jira/browse/GROOVY-12379
> Project: Groovy
> Issue Type: Improvement
> Reporter: Paul King
> Priority: Major
>
> Put the three module jars on the probe classpath, union their shipped
> metadata in the drift check, and exercise Path extensions, the XML
> parsers and builder, and JSON output and parsing. The strict-mode image
> found three gaps: groovy-xml's FactorySupport needs its JAXP ServiceLoader
> lookups and default implementations registered (generator gains a
> resources section), groovy-json needs its ServiceLoader-loaded string
> service (hand-written module metadata), and the Introspector's by-name
> resolution of Path's parameter types needs a hand-listed entry the JVM
> agent cannot record, now preserved across updateProbeMetadata.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
