[
https://issues.apache.org/jira/browse/GROOVY-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113201#comment-18113201
] ASF GitHub Bot commented on GROOVY-12383: ----------------------------------------- codecov-commenter commented on PR #2905: URL: https://github.com/apache/groovy/pull/2905#issuecomment-5598332027 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2905?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `68.42105%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 71.1904%. Comparing base ([`17b99a8`](https://app.codecov.io/gh/apache/groovy/commit/17b99a8c6c942b207257090e7ce795b34f58d8b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`74d9480`](https://app.codecov.io/gh/apache/groovy/commit/74d9480dc9576111657807e59f7bf43382cf88ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2905?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...in/java/org/codehaus/groovy/vmplugin/v9/Java9.java](https://app.codecov.io/gh/apache/groovy/pull/2905?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv9%2FJava9.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y5L0phdmE5LmphdmE=) | 68.4210% | [2 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2905?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2905?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2905 +/- ## ================================================== - Coverage 71.1943% 71.1904% -0.0040% + Complexity 37632 37629 -3 ================================================== Files 1581 1581 Lines 136251 136260 +9 Branches 25311 25313 +2 ================================================== + Hits 97003 97004 +1 - Misses 30511 30515 +4 - Partials 8737 8741 +4 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2905?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...in/java/org/codehaus/groovy/vmplugin/v9/Java9.java](https://app.codecov.io/gh/apache/groovy/pull/2905?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv9%2FJava9.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y5L0phdmE5LmphdmE=) | `59.8485% <68.4210%> (-1.9401%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2905/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > VM plugin: fall back to Java 8 accessibility rules when the module system is > absent > ----------------------------------------------------------------------------------- > > Key: GROOVY-12383 > URL: https://issues.apache.org/jira/browse/GROOVY-12383 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > Involves: a MODULES_AVAILABLE flag in the Java9 code, a guard around the > static initialiser that walks ModuleFinder, and three accessibility methods > delegating to the Java 8 versions when the flag is off. One catch: > GROOVY-11906 deprecated Java8, Java9, Java10 and Java16 for removal and left > only Java17 live, so this should land in whatever shape that collapse takes, > or it becomes churn twice. > Impact on normal usage: none, the flag is always true on a JVM. The cost is > one reflective lookup at plugin initialisation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
