[
https://issues.apache.org/jira/browse/GROOVY-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113203#comment-18113203
] ASF GitHub Bot commented on GROOVY-12384: ----------------------------------------- codecov-commenter commented on PR #2906: URL: https://github.com/apache/groovy/pull/2906#issuecomment-5598427544 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2906?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `57.14286%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 71.1820%. Comparing base ([`17b99a8`](https://app.codecov.io/gh/apache/groovy/commit/17b99a8c6c942b207257090e7ce795b34f58d8b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7651e96`](https://app.codecov.io/gh/apache/groovy/commit/7651e96c9512bed76ebc5de8ac5bda2612728a15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2906?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...haus/groovy/reflection/android/AndroidSupport.java](https://app.codecov.io/gh/apache/groovy/pull/2906?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Freflection%2Fandroid%2FAndroidSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3JlZmxlY3Rpb24vYW5kcm9pZC9BbmRyb2lkU3VwcG9ydC5qYXZh) | 44.4444% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2906?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...groovy/internal/runtime/invoke/InvokerFactory.java](https://app.codecov.io/gh/apache/groovy/pull/2906?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Finternal%2Fruntime%2Finvoke%2FInvokerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9pbnRlcm5hbC9ydW50aW1lL2ludm9rZS9JbnZva2VyRmFjdG9yeS5qYXZh) | 50.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2906?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2906?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2906 +/- ## ================================================== - Coverage 71.1943% 71.1820% -0.0124% + Complexity 37632 37620 -12 ================================================== Files 1581 1581 Lines 136251 136255 +4 Branches 25311 25311 ================================================== - Hits 97003 96989 -14 - Misses 30511 30523 +12 - Partials 8737 8743 +6 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2906?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ava/org/apache/groovy/util/HiddenClassDefiner.java](https://app.codecov.io/gh/apache/groovy/pull/2906?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Futil%2FHiddenClassDefiner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL0hpZGRlbkNsYXNzRGVmaW5lci5qYXZh) | `80.5195% <100.0000%> (ø)` | | | [...groovy/internal/runtime/invoke/InvokerFactory.java](https://app.codecov.io/gh/apache/groovy/pull/2906?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Finternal%2Fruntime%2Finvoke%2FInvokerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9pbnRlcm5hbC9ydW50aW1lL2ludm9rZS9JbnZva2VyRmFjdG9yeS5qYXZh) | `91.5385% <50.0000%> (-0.7692%)` | :arrow_down: | | [...haus/groovy/reflection/android/AndroidSupport.java](https://app.codecov.io/gh/apache/groovy/pull/2906?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Freflection%2Fandroid%2FAndroidSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3JlZmxlY3Rpb24vYW5kcm9pZC9BbmRyb2lkU3VwcG9ydC5qYXZh) | `38.4615% <44.4444%> (-28.2051%)` | :arrow_down: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2906/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Direct invokers: check for Android before touching HiddenClassDefiner > --------------------------------------------------------------------- > > Key: GROOVY-12384 > URL: https://issues.apache.org/jira/browse/GROOVY-12384 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Priority: Major > > Involves: swapping two lines in InvokerFactory.generationAllowed so the > existing Android check runs before HiddenClassDefiner.isEnabled(), and moving > the ClassOption array into a nested holder class so loading the definer does > not resolve a type ART lacks. > Impact on normal usage: none. The Android check is a cached boolean. -- This message was sent by Atlassian Jira (v8.20.10#820010)
