[
https://issues.apache.org/jira/browse/GROOVY-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113213#comment-18113213
] ASF GitHub Bot commented on GROOVY-12386: ----------------------------------------- codecov-commenter commented on PR #2908: URL: https://github.com/apache/groovy/pull/2908#issuecomment-5598805801 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2908?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `33.33333%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 71.1862%. Comparing base ([`17b99a8`](https://app.codecov.io/gh/apache/groovy/commit/17b99a8c6c942b207257090e7ce795b34f58d8b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`12b85e0`](https://app.codecov.io/gh/apache/groovy/commit/12b85e080ff76ed6b2af6339f6d046c2039c4bc2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2908?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...va/org/apache/groovy/json/internal/Exceptions.java](https://app.codecov.io/gh/apache/groovy/pull/2908?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FExceptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0V4Y2VwdGlvbnMuamF2YQ==) | 33.3333% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2908?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...main/java/org/apache/groovy/json/internal/Sys.java](https://app.codecov.io/gh/apache/groovy/pull/2908?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FSys.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL1N5cy5qYXZh) | 33.3333% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2908?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2908?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2908 +/- ## ================================================== - Coverage 71.1943% 71.1862% -0.0082% + Complexity 37632 37626 -6 ================================================== Files 1581 1581 Lines 136251 136261 +10 Branches 25311 25313 +2 ================================================== - Hits 97003 96999 -4 - Misses 30511 30520 +9 - Partials 8737 8742 +5 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2908?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...main/java/org/apache/groovy/json/internal/Sys.java](https://app.codecov.io/gh/apache/groovy/pull/2908?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FSys.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL1N5cy5qYXZh) | `35.2941% <33.3333%> (-1.3726%)` | :arrow_down: | | [...va/org/apache/groovy/json/internal/Exceptions.java](https://app.codecov.io/gh/apache/groovy/pull/2908?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FExceptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0V4Y2VwdGlvbnMuamF2YQ==) | `88.7324% <33.3333%> (-2.0368%)` | :arrow_down: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2908/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > groovy-json: keep System.Logger out of internal static initialisers > ------------------------------------------------------------------- > > Key: GROOVY-12386 > URL: https://issues.apache.org/jira/browse/GROOVY-12386 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > Involves: two internal classes, Sys and Exceptions, create a System.Logger in > a static field. The spike switched them to java.util.logging. A gentler > option is a lazy holder so the logger is only created when something is > actually logged, which is an error path in both classes. > Impact on normal usage: with the JUL switch, users who installed a custom > System.LoggerFinder would see these two rare messages routed differently. > With the lazy option nothing changes on a JVM, so I would prefer that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
