[
https://issues.apache.org/jira/browse/GROOVY-12382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113268#comment-18113268
] ASF GitHub Bot commented on GROOVY-12382: ----------------------------------------- codecov-commenter commented on PR #2904: URL: https://github.com/apache/groovy/pull/2904#issuecomment-5600454451 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2904?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.66667%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 71.1883%. Comparing base ([`17b99a8`](https://app.codecov.io/gh/apache/groovy/commit/17b99a8c6c942b207257090e7ce795b34f58d8b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2a37b78`](https://app.codecov.io/gh/apache/groovy/commit/2a37b78be132c2cb89d87dd3662d8590568d849b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2904?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...g/codehaus/groovy/vmplugin/JavaFeatureVersion.java](https://app.codecov.io/gh/apache/groovy/pull/2904?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2FJavaFeatureVersion.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL0phdmFGZWF0dXJlVmVyc2lvbi5qYXZh) | 83.3333% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2904 +/- ## ================================================== - Coverage 71.1943% 71.1883% -0.0061% + Complexity 37632 37629 -3 ================================================== Files 1581 1582 +1 Lines 136251 136264 +13 Branches 25311 25313 +2 ================================================== + Hits 97003 97004 +1 - Misses 30511 30519 +8 - Partials 8737 8741 +4 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2904?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...codehaus/groovy/control/CompilerConfiguration.java](https://app.codecov.io/gh/apache/groovy/pull/2904?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fcontrol%2FCompilerConfiguration.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NvbnRyb2wvQ29tcGlsZXJDb25maWd1cmF0aW9uLmphdmE=) | `74.8503% <100.0000%> (ø)` | | | [.../org/codehaus/groovy/vmplugin/VMPluginFactory.java](https://app.codecov.io/gh/apache/groovy/pull/2904?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2FVMPluginFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL1ZNUGx1Z2luRmFjdG9yeS5qYXZh) | `41.1765% <100.0000%> (+3.6765%)` | :arrow_up: | | [...g/codehaus/groovy/vmplugin/JavaFeatureVersion.java](https://app.codecov.io/gh/apache/groovy/pull/2904?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2FJavaFeatureVersion.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL0phdmFGZWF0dXJlVmVyc2lvbi5qYXZh) | `83.3333% <83.3333%> (ø)` | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2904/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > VMPluginFactory: tolerate a runtime without Runtime.version() > ------------------------------------------------------------- > > Key: GROOVY-12382 > URL: https://issues.apache.org/jira/browse/GROOVY-12382 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > Involves: a featureVersion() helper that tries Runtime.version(), then parses > java.specification.version, then assumes the lowest supported release, which > is the only plugin left anyway. Ten lines plus a unit test of the parsing. > Also worth reusing in CompilerConfiguration.defaultTargetBytecode, which has > the same call. > Impact on normal usage: none. On every JVM the first branch succeeds as > before. -- This message was sent by Atlassian Jira (v8.20.10#820010)
