[
https://issues.apache.org/jira/browse/GROOVY-12388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113229#comment-18113229
]
ASF GitHub Bot commented on GROOVY-12388:
-----------------------------------------
codecov-commenter commented on PR #2910:
URL: https://github.com/apache/groovy/pull/2910#issuecomment-5599148184
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2910?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 71.1960%. Comparing base
([`17b99a8`](https://app.codecov.io/gh/apache/groovy/commit/17b99a8c6c942b207257090e7ce795b34f58d8b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`e5cc553`](https://app.codecov.io/gh/apache/groovy/commit/e5cc553e6ef6951338fe68d608a0e97a27ee51e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2910 +/- ##
==================================================
+ Coverage 71.1943% 71.1960% +0.0016%
- Complexity 37632 37640 +8
==================================================
Files 1581 1581
Lines 136251 136276 +25
Branches 25311 25313 +2
==================================================
+ Hits 97003 97023 +20
- Misses 30511 30516 +5
Partials 8737 8737
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2910?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...n/java/org/codehaus/groovy/tools/DgmConverter.java](https://app.codecov.io/gh/apache/groovy/pull/2910?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2FDgmConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3Rvb2xzL0RnbUNvbnZlcnRlci5qYXZh)
| `96.2687% <100.0000%> (+0.3839%)` | :arrow_up: |
... and [11 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2910/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> DgmConverter: avoid MethodType constants in the adapter initialisers
> --------------------------------------------------------------------
>
> Key: GROOVY-12388
> URL: https://issues.apache.org/jira/browse/GROOVY-12388
> Project: Groovy
> Issue Type: Improvement
> Reporter: Paul King
> Assignee: Paul King
> Priority: Major
>
> Involves: the generated dgm$N classes load their target handle with an ldc
> MethodType, which D8 accepts only from API 28. Emitting a
> MethodType.methodType(Class, Class[]) call instead brings the floor back to
> API 26, where indy starts.
> Impact on normal usage: slightly larger adapter bytecode and a method call
> instead of a constant-pool resolution in each adapter's static initialiser,
> both negligible. The value is small too: Android 8 and 8.1 devices are around
> one percent of the installed base, so this is the one I would skip.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
