[
https://issues.apache.org/jira/browse/GROOVY-12385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113204#comment-18113204
] ASF GitHub Bot commented on GROOVY-12385: ----------------------------------------- codecov-commenter commented on PR #2907: URL: https://github.com/apache/groovy/pull/2907#issuecomment-5598490543 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2907?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `25.00000%` with `3 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 71.1884%. Comparing base ([`17b99a8`](https://app.codecov.io/gh/apache/groovy/commit/17b99a8c6c942b207257090e7ce795b34f58d8b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`910f5a2`](https://app.codecov.io/gh/apache/groovy/commit/910f5a2cef33cecbd95a100d3594f2c36e471775?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2907?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...a/org/apache/groovy/runtime/async/ScopedLocal.java](https://app.codecov.io/gh/apache/groovy/pull/2907?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fruntime%2Fasync%2FScopedLocal.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9ydW50aW1lL2FzeW5jL1Njb3BlZExvY2FsLmphdmE=) | 25.0000% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2907 +/- ## ================================================== - Coverage 71.1943% 71.1884% -0.0060% + Complexity 37632 37628 -4 ================================================== Files 1581 1581 Lines 136251 136254 +3 Branches 25311 25311 ================================================== - Hits 97003 96997 -6 - Misses 30511 30517 +6 - Partials 8737 8740 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2907?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/groovy/runtime/async/ScopedLocal.java](https://app.codecov.io/gh/apache/groovy/pull/2907?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fruntime%2Fasync%2FScopedLocal.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9ydW50aW1lL2FzeW5jL1Njb3BlZExvY2FsLmphdmE=) | `56.0000% <25.0000%> (-0.3954%)` | :arrow_down: | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2907/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > ScopedLocal: ScopedValue detection must not assume Runtime.version() > -------------------------------------------------------------------- > > Key: GROOVY-12385 > URL: https://issues.apache.org/jira/browse/GROOVY-12385 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > Involves: a local try/catch helper returning zero when the method is absent. > It has to stay local rather than reuse item 1, because groovy-concurrent-java > repackages this class without VMPluginFactory and has a self-containment test. > Impact on normal usage: none. -- This message was sent by Atlassian Jira (v8.20.10#820010)
