[
https://issues.apache.org/jira/browse/GROOVY-12000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113511#comment-18113511
] ASF GitHub Bot commented on GROOVY-12000: ----------------------------------------- codecov-commenter commented on PR #2914: URL: https://github.com/apache/groovy/pull/2914#issuecomment-5607453270 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2914?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `92.98246%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 71.1956%. Comparing base ([`9d91f7b`](https://app.codecov.io/gh/apache/groovy/commit/9d91f7b5533061f455123dad86af14eda01cdff8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`88971c6`](https://app.codecov.io/gh/apache/groovy/commit/88971c62788405dcbcea01fc4cb8da4a4a927e22?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2914?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2914?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh) | 92.9825% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2914?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2914?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2914 +/- ## ================================================== + Coverage 71.1893% 71.1956% +0.0063% - Complexity 37630 37665 +35 ================================================== Files 1581 1581 Lines 136255 136309 +54 Branches 25311 25328 +17 ================================================== + Hits 96999 97046 +47 - Misses 30518 30520 +2 - Partials 8738 8743 +5 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2914?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2914?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh) | `87.2134% <92.9825%> (+0.0935%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2914/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > STC: instanceof or combined with not > ------------------------------------ > > Key: GROOVY-12000 > URL: https://issues.apache.org/jira/browse/GROOVY-12000 > Project: Groovy > Issue Type: Bug > Components: Static Type Checker > Affects Versions: 6.0.0-alpha-1 > Reporter: Eric Milles > Priority: Major > > Consider the following: > {code:groovy} > @groovy.transform.TypeChecked > void test(Number number) { > if (!(number instanceof Cloneable || number instanceof Closeable)) { > number > } else { > number > } > } > {code} > Currently this passes the check for "can invert" and produces a type like > (Number & (Cloneable | Closeable))" for the else path. Not sure if we're > ready for that or not. -- This message was sent by Atlassian Jira (v8.20.10#820010)
